[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] Compose Box - Sent text remains in compose box after pressing return

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.50-2
Reproducible in staging?: Yes
Reproducible in production?: No

Issue reported by: @laurenreidexpensify '
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710165211864299

Action Performed:

1. Go www.staging.new.expensify.com
2. Open a chat
3. Send a message
4. Navigate to another chat
5. Navigate back to first chat

Expected Result:

The text editor is blank aside from the flashing cursor

Actual Result:

The compose box shows the text that has already been sent in the chat in the previous message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[mountiny]

Made a revert of a sus PR #38071

[mountiny]

The revert PR fixes this issue

[luacmartins]

Issue fixed in staging! Closing.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #32336 from callstack-internal/hur/perf/ch… #38071

If no regressions arise, payment will be issued on 2024-03-19. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @mountiny] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins / @mountiny] Determine if we should create a regression test for this bug.
• [@luacmartins / @mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Merge pull request #32336 from callstack-internal/hur/perf/ch… #38071

If no regressions arise, payment will be issued on 2024-03-20. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins / @mountiny] The PR that introduced the bug has been identified. Link to the PR: perf: improve chat switch performance #32336
• [@luacmartins / @mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: perf: improve chat switch performance #32336 (comment)
• [@luacmartins / @mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@luacmartins / @mountiny] Determine if we should create a regression test for this bug.
• [@luacmartins / @mountiny] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: