Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] Chat - Deleted parent message appears on main chat composer as unsent #38064

Closed
2 of 6 tasks
lanitochka17 opened this issue Mar 11, 2024 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.50-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+balto813@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to any chat
  2. Send message
  3. Hover over the message and select Reply in thread
  4. Add a reply
  5. Delete the parent message from thread page
  6. Click on header to navigate to main chat
  7. Send another message
  8. Hover over the message and select Reply in thread
  9. Add a reply
  10. Delete the parent message from thread page
  11. Click on header to navigate to main chat

Expected Result:

Deleted message should not re-appear on the main chat page

Actual Result:

Deleted parent message re-appears on main chat composer as unsent

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6409696_1710165961886.Recording__2547.1.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 11, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 11, 2024

Triggered auto assignment to @deetergp (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@lanitochka17
Copy link
Author

@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@deetergp
Copy link
Contributor

I'm not able to reproduce either locally nor in staging

Screen.Recording.2024-03-11.at.11.03.39.AM.mov

@mountiny
Copy link
Contributor

PR was CPed

@luacmartins
Copy link
Contributor

Seems to be fixed in staging https://expensify.slack.com/archives/C9YU7BX5M/p1710180647477529

@luacmartins luacmartins removed the DeployBlockerCash This issue or pull request should block deployment label Mar 11, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 12, 2024
@melvin-bot melvin-bot bot changed the title Chat - Deleted parent message appears on main chat composer as unsent [HOLD for payment 2024-03-19] Chat - Deleted parent message appears on main chat composer as unsent Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 12, 2024
Copy link

melvin-bot bot commented Mar 12, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.50-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-19. 🎊

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-19] Chat - Deleted parent message appears on main chat composer as unsent [HOLD for payment 2024-03-20] [HOLD for payment 2024-03-19] Chat - Deleted parent message appears on main chat composer as unsent Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-20. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants