Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pay now][$500] Payment for https://github.com/Expensify/App/pull/30829 #37798

Closed
mallenexpensify opened this issue Mar 5, 2024 · 8 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task

Comments

@mallenexpensify
Copy link
Contributor

mallenexpensify commented Mar 5, 2024

Which is part of

@mallenexpensify mallenexpensify added the Daily KSv2 label Mar 5, 2024
@mallenexpensify
Copy link
Contributor Author

@akinwale , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~01d7b0f6c0865460ec

@mallenexpensify mallenexpensify self-assigned this Mar 5, 2024
@mallenexpensify mallenexpensify changed the title Payment for https://github.com/Expensify/App/pull/30829 [Pay now][$500] Payment for https://github.com/Expensify/App/pull/30829 Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@akinwale
Copy link
Contributor

akinwale commented Mar 6, 2024

@mallenexpensify Accepted. Thanks!

@mallenexpensify
Copy link
Contributor Author

@akinwale can you comment on the PR here. I want to know if there's a regression and compensation should be reduce by 50%

This line caused crash - #36834
source is not always string, i.e. svg

@mallenexpensify mallenexpensify added the Awaiting Payment Auto-added when associated PR is deployed to production label Mar 7, 2024
@akinwale
Copy link
Contributor

akinwale commented Mar 7, 2024

@mallenexpensify It appears that the regression came from the PR, but it's an edge case that we wouldn't have been able to catch over the course of testing the video playback feature.

@mallenexpensify
Copy link
Contributor Author

Thanks @akinwale to close the loop, for 'edge case' you're saying it falls under this part of the C+ process doc

*“Should have” = C+ should have caught the bug by fully following the checklist. If C+ skips a step or completed the checklist incompletely, payment will be cut in half.

Is that correct? (asking cuz I want to know if we need to consider updating anything)

@akinwale
Copy link
Contributor

Is that correct? (asking cuz I want to know if we need to consider updating anything)

Yes, this seems to be the case. The bug happens when viewing a workspace avatar, not with the video player itself.

@mallenexpensify
Copy link
Contributor Author

Contributor+: @akinwale paid $500 via Upwork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Task
Projects
None yet
Development

No branches or pull requests

2 participants