Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here #37758

Closed
3 of 6 tasks
lanitochka17 opened this issue Mar 5, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.47
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4382182
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Launch app
  2. Tap fab-- request money---scan
  3. Upload image using camera
  4. Select 2 contacts as split
  5. Complete the flow & tap split
  6. Open the newly created expense
  7. Enter an amount
  8. Tap split
  9. Open the newly created expense
  10. In details page, tap individual split amount
  11. Tap message user
  12. Tap individual IOU to open details page

Expected Result:

On scan split with 2 users, individual IOU details page must show IOU details

Actual Result:

On scan split with 2 users, individual IOU details
page shows hhm not here

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6402828_1709645645822.fab.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014b9c1a7230c9adfe
  • Upwork Job ID: 1765081849283305472
  • Last Price Increase: 2024-03-05
@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

@flodnv FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@flodnv flodnv added the External Added to denote the issue can be worked on by a contributor label Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014b9c1a7230c9adfe

@melvin-bot melvin-bot bot changed the title IOU - On scan split with 2 users, individual IOU details page shows hhm not here [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here Mar 5, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@flodnv
Copy link
Contributor

flodnv commented Mar 5, 2024

@flodnv
Copy link
Contributor

flodnv commented Mar 5, 2024

Tried twice, I can't reproduce, asking for a retest here: https://expensify.slack.com/archives/C9YU7BX5M/p1709666257616979?thread_ts=1709665678.964929&cid=C9YU7BX5M

@flodnv
Copy link
Contributor

flodnv commented Mar 5, 2024

I think I was able to reproduce? Unsure, I am not getting the "not found" page, but I am getting an infinite loading skeleton.. The only thing I did differently was to use an inexistent account for the split.

@flodnv
Copy link
Contributor

flodnv commented Mar 5, 2024

I can also reproduce by clicking on the IOU on the receiving account, and can confirm this is not reproducible in production. Next step would be to reproduce on dev and git bisect, but unfortunately I'm out for the day.

@roryabraham roryabraham self-assigned this Mar 5, 2024
@paultsimura
Copy link
Contributor

One eternity later, I managed to find the offending PR: #36713
It's the onyx bump from 2.0.7 to 2.0.10 that causes the regression, confirmed by reverting to 2.0.7.

@roryabraham
Copy link
Contributor

@paultsimura is checking if this is fixed by #37804

I was able to reproduce this on dev but was getting an image upload error earlier on when initiating a smartscan, so I'm not sure if I was experiencing the same issue or a dev environment issue

@roryabraham
Copy link
Contributor

should be fixed by #37804

@roryabraham
Copy link
Contributor

@roryabraham roryabraham removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 6, 2024
@kavimuru
Copy link

kavimuru commented Mar 6, 2024

Bug is fixed in the build 1.4.47-7.

Sch4.mp4

@flodnv
Copy link
Contributor

flodnv commented Mar 6, 2024

Thanks!!! 👌

@flodnv flodnv closed this as completed Mar 6, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here [HOLD for payment 2024-03-13] [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment (Needs manual offer from BZ)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 7, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-03-13] [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here [HOLD for payment 2024-03-14] [HOLD for payment 2024-03-13] [$500] IOU - On scan split with 2 users, individual IOU details page shows hhm not here Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.48-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @s77rt requires payment (Needs manual offer from BZ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants