Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Snyk] Security upgrade electron-builder from 24.6.4 to 24.13.2 #37745

Closed
melvin-bot bot opened this issue Mar 5, 2024 · 6 comments
Closed

[Snyk] Security upgrade electron-builder from 24.6.4 to 24.13.2 #37745

melvin-bot bot opened this issue Mar 5, 2024 · 6 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Mar 5, 2024

This PR was automatically created by Snyk using the credentials of a real user.


Snyk has created this PR to fix one or more vulnerable packages in the `npm` dependencies of this project.

Changes included in this PR

  • Changes to the following files to upgrade the vulnerable dependencies to a fixed version:
    • package.json
    • package-lock.json

Vulnerabilities that will be fixed

With an upgrade:
Severity Issue Breaking Change Exploit Maturity
high severity Untrusted Search Path
SNYK-JS-APPBUILDERLIB-6371201
No Proof of Concept

Check the changes in this PR to ensure they won't cause issues with your project.


Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report

🛠 Adjust project settings

📚 Read more about Snyk's upgrade and patch logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~015cf1722cc6e17269
  • Upwork Job ID: 1765012008362926080
  • Last Price Increase: 2024-03-05
@melvin-bot melvin-bot bot added Internal Requires API changes or must be handled by Expensify staff Weekly KSv2 labels Mar 5, 2024
Copy link
Author

melvin-bot bot commented Mar 5, 2024

This is a Snyk issue. Snyk is a tool that automatically tracks our repositories' dependencies and reports associated security vulnerabilities. It also automatically create PRs to fix these vulnerabilities.

    C+: Please follow these steps to test the linked PR before running through the reviewer checklist:
    - [ ] The first step is to understand the PR: what dependency is it upgrading, for which vulnerability, how it impacts our product & end users.
    - [ ] If the issue is not worth fixing, please add your reasoning in the issue and have the internal engineer review it.
    - [ ] Check the change log (which should be included in the PR description) to see all changes. We want to identify any breaking changes. If it is a minor version bump, it's unlikely that there are any breaking changes.
    - [ ] Test our feature(s) that make use of this package. If it does not work, we should understand what broke it. It is also a good idea to check our main flows to make sure they are not broken that you can add in the checklist screenshots/videos.

Copy link
Author

melvin-bot bot commented Mar 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~015cf1722cc6e17269

Copy link
Author

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @eh2077 (Internal)

@eh2077
Copy link
Contributor

eh2077 commented Mar 6, 2024

I think this can be closed as #37744 was merged.

Try to add C+ stamp here to move forward.

🎀 👀 🎀
C+ Reviewed

Hmm, seems adding C+ stamp is working.

@neil-marcellini Kindly help to close this, thanks!

@eh2077 eh2077 removed their assignment Mar 6, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Apr 5, 2024
Copy link
Author

melvin-bot bot commented Apr 5, 2024

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 5, 2024
@neil-marcellini neil-marcellini self-assigned this Apr 5, 2024
@neil-marcellini
Copy link
Contributor

Ah yep this was done a while ago. Thanks @eh2077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Development

No branches or pull requests

2 participants