Android - Workspace - Workspace name is not fully displayed on Profile page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.45-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): gocemate@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Sign in with Gmail account
2. Go to Settings> Create new Workspace
3. Navigate to Profile

Expected Result:

Workspace name should be fully displayed

Actual Result:

Workspace name is not fully displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

Production:

Recording.2421.mp4

[lanitochka17]

@hayata-suenaga FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[rushatgabhane]

not a bug. looks like it's intentional

[apeyada]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android - Workspace - Workspace name is not fully displayed on Profile page

What is the root cause of that problem?

App/src/components/MenuItem.tsx

Lines 520 to 528 in c2e24e1

	{!shouldRenderAsHTML && !shouldParseTitle && !!title && (
	<Text
	style={combinedTitleTextStyle}
	numberOfLines={numberOfLinesTitle || undefined}
	dataSet={{[CONST.SELECTION_SCRAPER_HIDDEN_ELEMENT]: interactive && disabled}}
	>
	{renderTitleContent()}
	</Text>
	)}

There's no style property in combinedTitleTextStyle which stretches text to the full width.

What changes do you think we should make in order to solve the problem?

add flex: 1 or width: '100%' under the condition of (!shouldShowTitleIcon || !titleIcon) &&

Note: this is android only issue and same root cause as #21219 or #24339, but this solution (kind of workaround) is already applied in other places of the app. #30023 is a good example

[hayata-suenaga]

looking at this right now 👀

[hayata-suenaga]

yep this clearly looks like intentional change.

@lanitochka17 did you have any TestRail case that specify that the workspace name should be fully displayed?

[hayata-suenaga]

anyway, closing this for now