Tax amount is not automatically computed when creating request via FAB

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when executing PR : #36784

Version Number: v1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has tax enabled.

1. Go to workspace chat.
2. Click + > Request money > Manual.
3. Enter amount > Next.
4. Click Show more.
5. Note that tax amount is computed.
6. Go to FAB > Request money > Manual.
7. Enter amount.
8. Select the Collect workspace.
9. Click Show more.

Expected Result:

Tax amount will be not computed.

Actual Result:

Tax amount is not computed.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6395218_1709110829868.20240228_131855.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

@strepanier03 I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[MonilBhavsar]

Feature is WIP, so we can put this HOLD until we finish the implementation as it is being rolled out in phases https://github.com/Expensify/Expensify/issues/305057

[strepanier03]

Sounds good, thanks @MonilBhavsar!

[strepanier03]

Hold still.

[strepanier03]

Still on Hold.

[strepanier03]

Still paused while HOLD GH is open.

[MonilBhavsar]

@strepanier03 this issue is now fixed. Feel free to retest and close it

[strepanier03]

Great, I'll test and update. Thanks @MonilBhavsar!

[strepanier03]

Hmmm, this still isn't working for me on Safari at least, testing on Chrome as well, then I'll update with video/screenshots.

[strepanier03]

Testing notes

Collect Workspace tax setup

---

No matter how I create an expense, the tax amount isn't calculated, I have to toggle the rate in the tax selection dropdown to get it to calculate. Video below in Safari.

2024-04-17_14-41-25.mp4

The behavior is the same in Chrome as well.

2024-04-17_14-53-32.mp4

[strepanier03]

@MonilBhavsar—Maybe I'm confused. Should the expected behavior be that the tax is automatically calculated? That is what I was expecting, but not what I'm experiencing.

[strepanier03]

I'm still unable to have a tax calculated automatically. It's only calculated when I toggle the rate applied. This is unexpected from what I'm gathering in https://github.com/Expensify/Expensify/issues/305057.

I made a brand new collect workspace, and tried to create an expense from both the FAB and the smaller + in the workspace thread.

FAB:

From Workspace chat > small + > Submit expense

@MonilBhavsar - Am I holding this wrong somehow? Are you able to get an expense's tax amount to calculate automatically without toggling?

[strepanier03]

@MonilBhavsar - I'm going to set this to External and get it looked at unless you think otherwise. I can't create an expense and have tax computed unless I toggle between two rates.

[MonilBhavsar]

Interesting, I'll retest today

[MonilBhavsar]

Tax amount is showing correct for me

Screen.Recording.2024-05-15.at.11.05.48.AM.mov

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[MonilBhavsar]

Thanks! Let's close it