[HOLD for payment 2024-03-29] [$500] Web - Chat - Infinite spinner in ND when navigating from OD in different ways

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.44-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/cases/view/1971109
Issue reported by: Applause - Internal team

Action Performed:

Precondition: user is logged in OD with an account that has a existing workspace without a bank account setup

1. Navigate to inbox and Search for the inbox task "Finish setting up..."
2. Click on "Continue Setup"
   OR
3. Click the message bubble in the bottom right

Expected Result:

User redirected to ND and the "Connect Bank Account" page is displayed in the side bar.
OR
A new tab opens and user is brought to the ND concierge chat.

Actual Result:

User is redirected to ND and see infinite spinner instead of chat history.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394386_1709056504536.Confirm_Setup.mp4

Bug6394386_1709056504539.Message_bubble.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01245ae49f9d1205bf
• Upwork Job ID: 1762543109358874624
• Last Price Increase: 2024-03-12

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01245ae49f9d1205bf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave5-free-submitters
CC @dylanexpensify

[robertjchen]

Definitely a blocker for sure

[robertjchen]

Working on reproducing the issue

[robertjchen]

I believe it's related to this change: #36689

This is happening on the OpenReimbursementAccountPage and the most recent changes to that flow were related to the above PR. There's no console error and just the infinite spinner so I'm not too sure how to debug further. @nkuoch @hayata-suenaga do you possibly have more insight into what may be happening here?

[hayata-suenaga]

I think there are two parts to this issue:

• The first part is the infinite loading of the chat history
• The second part is that the bank setup RHP is not showing up

The second point might be related to @nkuoch's PR but for the first part, I'm not sure if the PR is directly related 🤔
For the second point, the deep linking might not be working as expected cc: @nkuoch

[nkuoch]

I started looking and it doesn't seem related to my PR as it seem to be happening for any /transition redirections to newDot .. but I could be wrong .. Looking a bit more for the next 30mn but then will need to go

[hayata-suenaga]

@robertjchen seems like the PR is not related. do you have any idea what might be related?

[nkuoch]

Might be worth doing a git bisect

[robertjchen]

Got it, thanks for taking a look. I'll dig further!

[robertjchen]

Posted in #wave9-collect-signups to get additional insight, thanks for the tip @hayata-suenaga !

[robertjchen]

Reproducible here and appears to affect all OldDot -> NewDot transitions: https://expensify.slack.com/archives/CC7NECV4L/p1710532758907999

[mountiny]

PR is coming from @adamgrzybowski

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix infinite spinner in ND when navigating from OD #38567

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[mountiny]

$500 to @allroundexperts for their review

[adelekennedy]

sorry @allroundexperts I'm just back from ooo

Payouts due:

• Contributor+: $500 @allroundexperts (NewDot)

[JmillsExpensify]

$500 approved for @allroundexperts