Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] iOS - Settings - The keyboard appears with a black background that changes to grey #37301

Closed
1 of 6 tasks
kbecciv opened this issue Feb 27, 2024 · 7 comments
Closed
1 of 6 tasks
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.44.0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team
Issue found when executing PR: #35326

Action Performed:

  1. Go to personal details
  2. Tap on address
  3. Tap on country
  4. Navigate back
  5. Tap on country again

Expected Result:

It should only show a grey background.

Actual Result:

The keyboard appears with a black background that changes to grey.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6393976_1709037272812.VYHS1315.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0196694799b239c5ad
  • Upwork Job ID: 1762484844314882048
  • Last Price Increase: 2024-02-27
@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0196694799b239c5ad

@melvin-bot melvin-bot bot changed the title iOS - Settings - The keyboard appears with a black background that changes to grey [$500] iOS - Settings - The keyboard appears with a black background that changes to grey Feb 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@ikevin127
Copy link
Contributor

ikevin127 commented Feb 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue

I was not able to find any offending PR within the deploy checklist, so I'm assuming this was not caused by the latest deploy.

What is the root cause of that problem?

We're not leveraging the iOS specific keyboardAppearance TextInput prop and because of this, the 'default' applies which will default to the appearance that the user has set globally on their device, which typically is a light keyboard but will be dark if the user has chosen to use the system-wide dark mode in their iOS settings.

This can cause the unwanted transition from dark to light if not specifically set.

What changes do you think we should make in order to solve the problem?

Since the Expected result states:

It should only show a grey background.

this means we always want to show the light keyboard background.

For this we should explicitly set keyboardAppearance to light here.

Videos

iOS: Native
Before After
before.mov
after.mov

@mkhutornyi
Copy link
Contributor

I think #29991 is the offending PR.
So retest after #37305 is deployed to staging

@puneetlath
Copy link
Contributor

Can confirm it's working fine now after the revert. Closing this issue, but feel free to reopen if there's still something that needs to be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants