[$500] Tag - No violation message for missing tag when tag is not selected

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.43-2
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition::

• User is an employee of Collect workspace.
• The Collect workspace has tags and Tag is set to "Required".

1. Navigate to staging.new.expensify.com
2. Go to workspace chat.
3. Create a manual request without tag.
4. Navigate to request details page.

Expected Result:

There will be a violation message for missing tag.

Actual Result:

There is no violation message for missing tag.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385600_1708428087038.bandicam_2024-02-20_14-55-24-904.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01651062d96a32e6ea
• Upwork Job ID: 1759949751406247936
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01651062d96a32e6ea

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related to #wave6-collect-submitters
CC @greg-schroeder

[pecanoro]

Reproduced! It's indeed a regression!

[pecanoro]

Found the PR and left a comment to see what we do next since we might have a PR in progress

[rezkiy37]

I am an author of a broken PR. However, I see that there is already a work in progress. If you need any help from me, please let me know.

[kmbcook]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag - No violation message for missing tag when tag is not selected, for manual workspace money request.

What is the root cause of that problem?

Tag is not treated as a required field, in workspace money request when it should be.

What changes do you think we should make in order to solve the problem?

Check policy to see if tag is required. If so, treat tag field as required in the same way that merchant field is required. Doing so will not permit user to create a manual money request without tag.

[melvin-bot]

Current assignee @rushatgabhane is eligible for the Internal assigner, not assigning anyone new.

[cead22]

Violations are in beta so this shouldn't be a blocker, and I'm working on the fix

[melvin-bot]

@cead22, @pecanoro Whoops! This issue is 2 days overdue. Let's get this updated quick!

[pecanoro]

This is on prod already, closing!