[HOLD for payment 2024-03-29] [$500] Android - IOU - The "Take a photo" background animation is stuck

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Reinstall the app
2. Log in for the first time
3. Tap on FAB -> Request money -> Scan

Expected Result:

The animation should be completed.

Actual Result:

The "Take a photo" background animation is stuck.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379807_1707938425262.az_recorder_20240214_160812.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c2cca67bbda25bba
• Upwork Job ID: 1757910328375115776
• Last Price Increase: 2024-02-21
• Automatic offers:
• mollfpr | Reviewer | 0
• aswin-s | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c2cca67bbda25bba

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[marcaaron]

Hmm I have no idea. Seems like it could be related to expo-image. The code where this is rendered is here:

https://github.com/Expensify/App/blame/0381d57ab7a127371cdea766e118ce0290be1eaf/src/pages/iou/request/step/IOURequestStepScan/index.native.js#L279-L285

With the most recent change to the file being in this PR (which is on staging).

[marcaaron]

Doesn't really seem related to those changes though.

@kavimuru Can we try to re-test this on other Android devices?

I am curious if this is an expo-image issue.

cc @Beamanator I think this is not a blocker. The flow looks pretty good on Android without the animation so I think we can pursue a fix without blocking the deploy.

[marcaaron]

FWIW I was able to repro this. But don't think it looks that bad so removed the blocker.

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Navigation to RequestMoneyStartPage is stuck when camera permission is requested

What is the root cause of that problem?

This is related to #35640 where we are requesting camera permission on page load.

App/src/pages/iou/request/step/IOURequestStepScan/index.native.js

Line 139 in d88bdf3

refreshCameraPermissionStatus(true);

However we are not waiting for the navigation animation to finish before requesting for camera permission. This causes the animation to freeze in between.

What changes do you think we should make in order to solve the problem?

Run permission check only after screen animation is finished. For this useFocusEffect instead of useEffect in combination with InteractionManager.runAfterInteractions. This ensures that permission check is triggered only after animation is finished.

useFocusEffect( useCallback(() => {
  // Check initial camera permission status
   InteractionManager.runAfterInteractions(() => {
     refreshCameraPermissionStatus(true);
   });
 }))

This ensures that screen animation is not interupted

What alternative solutions did you explore? (Optional)

None

[ikevin127]

If this is indeed a regression from PR #35640 I think the PR author should handle the regression fix ♻️

[mollfpr]

If this is indeed a regression from PR #35640 I think the PR author should handle the regression fix ♻️

I'm not sure about this, but my understanding is that @marcaaron stated this wasn't regression from that PR.

I also check that the PR recordings on Android seem working just fine. @aswin-s What's the different in this issue?

[melvin-bot]

@kevinksullivan, @mollfpr, @marcaaron Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mollfpr]

I also check that the PR recordings on Android seem working just fine. @aswin-s What's the different in this issue?

Friendly bump @aswin-s

[mollfpr]

untitled.1.mp4

I still can see the screen stuck a little bit.

[aswin-s]

@mollfpr Ok, I'll raise the PR shortly

[melvin-bot]

@aswin-s @kevinksullivan @mollfpr @marcaaron this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @mollfpr is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.55-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: request camera permission only after screen transition is complete #38270

If no regressions arise, payment will be issued on 2024-03-29. 🎊

For reference, here are some details about the assignees on this issue:

• @aswin-s requires payment automatic offer (Contributor)
• @mollfpr requires payment automatic offer (Reviewer)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr] Determine if we should create a regression test for this bug.
• [@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr] The PR that introduced the bug has been identified. Link to the PR:
[@mollfpr] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

I don't think any PR is causing the issue.

[@mollfpr] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be enough.

[@mollfpr] Determine if we should create a regression test for this bug.
[@mollfpr] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Reinstall the app on a native device
2. Log in for the first time
3. Tap on FAB -> Request money -> Scan
4. Verify that the screen transition animation is smooth and not interrupted in the middle by the camera permission dialog
5. 👍 or 👎

---

@kevinksullivan Could you create the payment summary? Thank you!

[mollfpr]

Friendly bump @kevinksullivan

[mollfpr]

Friendly bump @kevinksullivan

[aswin-s]

@kevinksullivan Gentle reminder

[kevinksullivan]

Payment summary:

• C+: @mollfpr - $500 (NewDot)
• Contributor: @aswin-s $500

[JmillsExpensify]

$500 approved for @mollfpr