IOU - Billable no longer valid violation is not displayed under the field

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4312606
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Pre-requisite: as an employee of a workspace, create an expense with Billable option toggled on.

1. As the admin of the workspace on OD, set "Re-bill expenses to clients" to Disabled.
2. As the employee on ND, go to the details page of the created expense.

Expected Result:

Billable no longer valid violation should be displayed under the field.

Actual Result:

Billable no longer valid violation is displayed on the right side and the toggle button is moved to the middle.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[kbecciv]

We think that this bug might be related #wave6-collect-submitters
CC @greg-schroeder

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Billable no longer valid violation is not displayed under the field

What is the root cause of that problem?

We are displaying the violation incorrectly. It should be after this View

What changes do you think we should make in order to solve the problem?

We should move ViolationMessage after this View

[pecanoro]

@kbecciv On production, does it show under the button or it doesn't show at all?

[amyevans]

@cead22 @trevor-coleman is this an expected change?

[trevor-coleman]

No it should be underneath. Moving it outside that view should fix it.

[amyevans]

@trevor-coleman Got it, thanks! could you open a PR to fix please?

[neonbhai]

Would love to raise the PR if needed!

[pecanoro]

I need to check if this a regression for a PR or it was introduced by a new feature

[amyevans]

@pecanoro it's from #34303

[pecanoro]

@amyevans Thank you! So it was a regression from that PR. As she mentioned, @trevor-coleman can you fix it since it was your PR or should we find a volunteer?

[trevor-coleman]

I've got a fix done just making a PR now--the screenshots will take some time.

[pecanoro]

@trevor-coleman Cool, thank you so much!

[trevor-coleman]

Because of the difference between web and native, just moving the messages below wasn't working, so I ended up leaving the violation messages where they are adding override props to the container and text styles that let me put them where they needed to be.

Android:

Web:

[trevor-coleman]

PR is up: #36533

[pecanoro]

Either way, since it's just visual and it does not break things completely, I am going to remove the deploy blocker and we can merge it tomorrow. @cead22 Do you agree?

[aimane-chnaif]

violations is still in beta so not deploy blocker

[pecanoro]

Issue for payment created, gonna closed this one