[$500] [MEDIUM] Second and third numbers are filled with green after completing personal info

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings from the bottom.
3. Click any workspace.
4. Click Bank account.
5. Click Connect manually.
6. Proceed until "Personal info" is complete.
7. Proceed to Business info.

Expected Result:

3rd circle shouldn't be filled green

Actual Result:

2nd and 3rd are filled green

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240214_050337.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0134677950b2ff2b02
• Upwork Job ID: 1757557097541500928
• Last Price Increase: 2024-02-14
• Automatic offers:
• akinwale | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0134677950b2ff2b02

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[jeremy-croff]

The step it's skipping is biometric data. are you using any particular account information that bypasses this? Cannot reproduce this myself.

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Second and third numbers are filled with green after completing personal info

What is the root cause of that problem?

The step is 2 but we have passed it as 3:

App/src/pages/ReimbursementAccount/BusinessInfo/BusinessInfo.tsx

Line 113 in 023d62c

startStepIndex={3}

This in turn triggers the isCompleted to true and we get a filled color:

App/src/components/InteractiveStepSubHeader.tsx

Line 57 in 023d62c

const isCompletedStep = currentStep > index;

What changes do you think we should make in order to solve the problem?

Pass the correct step number i.e. 2

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @akinwale 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

I agree with @jeremy-croff this is skipping the identity verification probably because the account Applause used is whitelisted

[MrMuzyk]

This is intended behaviour. This specific set of data skips onfido step. Try using regular values and you will see that onfido will show after personal info step