Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onfido triggers after personal info step instead of after Business information steps #36447

Closed
2 of 6 tasks
kavimuru opened this issue Feb 13, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kavimuru
Copy link

kavimuru commented Feb 13, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.41-1
Reproducible in staging?: y
Reproducible in production?: n (New flow)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Create workspace
  2. Open workspace settings
  3. Click on bank account
  4. Enter routing number and account number manually
  5. Fill in Legal name
  6. Fill in DOB in the next screen
  7. Enter SSN in the next page
  8. Enter address and click continue

Expected Result:

Taken to business information page as per this documents https://docs.google.com/document/d/1J9vCa6j6ue2dLbCO99TAPudZNuNlljCNMjdT5FMgGy4/edit

Actual Result:

Taking to Onfido flow

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6378756_1707866446918.bandicam_2024-02-14_00-58-52-995.mp4

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2024

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@mountiny
Copy link
Contributor

@kavimuru Do you have a video for this one?
cc @barttom @MrMuzyk @akinwale @shubham1206agra

@kavimuru
Copy link
Author

@mountiny added now. Sorry got missed when creating ticket.

@mountiny mountiny assigned akinwale and mountiny and unassigned neil-marcellini Feb 14, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 14, 2024
@mountiny
Copy link
Contributor

Thanks for adding that.

I can confirm that the designs also suggest that the 3rd step would be business step and the 4th step would be onfido.

I feel like there must have been some reason the order got flipped so I think its not a blocker since this is how backend expects it @nkuoch @MrMuzyk @barttom if you happen to have a link to some comment this could have been mentioned at

@shubham1206agra
Copy link
Contributor

@nkuoch Worked on this

@nkuoch nkuoch self-assigned this Feb 14, 2024
@nkuoch
Copy link
Contributor

nkuoch commented Feb 14, 2024

This is expected. Onfido view is skipped only when using the test credentials

@nkuoch nkuoch closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
No open projects
Development

No branches or pull requests

7 participants