[HOLD for payment 2024-02-26] Reimbursements - Error message is not left aligned to other items

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.41-2
Reproducible in staging?: y
Reproducible in production?: n (new feature)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Open workspace settings page
2. Click on 'Reimbursements'
3. Click on 'Rate'
4. Click on 'Rate' again
5. Reset the value to '0'
6. Click 'Save'

Expected Result:

Error message should be left aligned with back & save button

Actual Result:

Error message is not left aligned with back & save button

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[habasefa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The form validation error message is out of alignment, not left aligned.

What is the root cause of that problem?

The form validation error message has zero padding and margin. Therefore, it is attached to the left side of the screen.

What changes do you think we should make in order to solve the problem?

Adding left padding like the other items, and making it align with them.
{!!errorText && (
<FormHelpMessage
style={[styles.pAbsolute, styles.b0, styles.mb0, styles.w100, styles.pl5]}
isError
message={errorText}
/>
)}

What alternative solutions did you explore? (Optional)

Tried adding a left margin but that is working only for the web.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reimbursements - Error message is not left aligned to other items

What is the root cause of that problem?

There's no margin/padding style set in form and button

App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

Lines 84 to 93 in 148733c

	<FormProvider
	formID={ONYXKEYS.FORMS.WORKSPACE_RATE_AND_UNIT_FORM}
	submitButtonText={translate('common.save')}
	validate={validate}
	onSubmit={submit}
	enabledWhenOffline
	style={[styles.flexGrow1]}
	shouldHideFixErrorsAlert
	submitFlexEnabled={false}
	submitButtonStyles={[styles.mh5, styles.mt0]}

What changes do you think we should make in order to solve the problem?

1. add styles.ph5
   

   App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

   Line 90 in 148733c

   style={[styles.flexGrow1]}

2. remove styles.mh5 and update styles.mt0 to styles.mt3
   

   App/src/pages/workspace/reimburse/WorkspaceRateAndUnitPage/RatePage.tsx

   Line 93 in 148733c

   submitButtonStyles={[styles.mh5, styles.mt0]}

Result: (perfectly match with money request amount form)

[ZhenjaHorbach]

It looks like new component from this PR
#34849

[Beamanator]

@ZhenjaHorbach Agreed it looks like this came from #34849 - @shubham1206agra can you look into fixing this?

[shubham1206agra]

Going to combine it with #36438

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[hayata-suenaga]

being fixed in this PR

[thienlnam]

Removing the blocker
#36549 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fixed currency pressable ui and padding issues #36497

If no regressions arise, payment will be issued on 2024-02-26. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hayata-suenaga] The PR that introduced the bug has been identified. Link to the PR:
• [@hayata-suenaga] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hayata-suenaga] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hayata-suenaga] Determine if we should create a regression test for this bug.
• [@hayata-suenaga] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kevinksullivan] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[hayata-suenaga]

The PR that introduced the bug has been identified. Link to the PR

#34849

The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#34849 (comment)

A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

No need for this

Determine if we should create a regression test for this bug.

No need for a new regression test

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

N/A

[kevinksullivan]

Payment summary:

• Contributor review: @allroundexperts $250

[JmillsExpensify]

$250 approved for @allroundexperts based on summary above.