[$500] The back tooltip floats when we return from the Search.

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.38-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause internal team

Action Performed:

1, Click on "Search."
2, Upon returning from the search, observe that the back tooltip unexpectedly floats.

Expected Result:

The back tooltip should disappear when the modal is closed.

Actual Result:

The back tooltip floats when we return from the Search.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

floating.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a6a56ddf6a62fbf6
• Upwork Job ID: 1755487058087190528
• Last Price Increase: 2024-02-15
• Automatic offers:
• fedirjh | Contributor | 28150026

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cead22 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[cead22]

This doesn't feel like a blocker, @greg-schroeder can you put it through the regular bug process please?

[greg-schroeder]

Agreed not a blocker, setting External and leaving Daily

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a6a56ddf6a62fbf6

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The back tooltip floats when we return from the Search.

What is the root cause of that problem?

We are not passing onBackButtonPress={Navigation.goBack} to HeaderWithBackButton in SearchPage and due to this when clicking on the back button the route is changed to home route instead of the previous route causing a delay in animations and disruptions in layouts.

App/src/components/HeaderWithBackButton/index.tsx

Line 29 in 02f0613

onBackButtonPress = () => Navigation.goBack(ROUTES.HOME),

What changes do you think we should make in order to solve the problem?

Pass onBackButtonPress={Navigation.goBack} to HeaderWithBackButton in SearchPage.

App/src/pages/SearchPage/index.js

Line 149 in 02f0613

<HeaderWithBackButton title={translate('common.search')} />

The same issue doesn't happen with WorkspaceSwitcherPage because we pass the onBackButtonPress={Navigation.goBack} prop.

App/src/pages/WorkspaceSwitcherPage.tsx

Lines 291 to 293 in 02f0613

	<HeaderWithBackButton
	title={translate('workspace.switcher.headerTitle')}
	onBackButtonPress={Navigation.goBack}

Result

tooltip_float.mp4

Alternative

Change the default value of onBackButtonPress inside HeaderWithBackButton to Navigation.goBack.

[Krishna2323]

@greg-schroeder, I think you unassigned @fedirjh by mistake.

[greg-schroeder]

Yes I did, that was an accident. I've rescinded that offer, silly automatation 😅

[nduisekeyev]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The back tooltip floats from the workspace switcher.

What is the root cause of that problem?

The absence of the second argument in the HeaderWithBackButton from the Navigation library, which is responsible for enforcing navigation to the fallback route, results in the floating of the back tooltip.

App/src/libs/Navigation/Navigation.ts

Line 185 in 9922a39

function goBack(fallbackRoute?: Route, shouldEnforceFallback = false, shouldPopToTop = false) {

What changes do you think we should make in order to solve the problem?

By passing Navigation.goBack(ROUTES.HOME, true) to the onBackButtonPress prop, we're ensuring that the goBack function is called with the appropriate arguments, including the fallback route (ROUTES.HOME) and the shouldEnforceFallback flag set to true in the HeaderWithBackButton.

App/src/components/HeaderWithBackButton/index.tsx

Line 29 in 9922a39

onBackButtonPress = () => Navigation.goBack(ROUTES.HOME),

Screenshots/Videos

screenshoot_video.mov

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

📣 @nduisekeyev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[nduisekeyev]

Contributor details
Your Expensify account email: nur.duisekeyev@hotmail.com
Upwork Profile Link: https://www.upwork.com/fl/~01ab96855ba9fc9fc4

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[fedirjh]

Unable to reproduce on staging v1.4.40-1

CleanShot.2024-02-12.at.22.30.07.mp4

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Adding retest label to have QA confirm if this is still an issue

[melvin-bot]

@greg-schroeder, @fedirjh Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[greg-schroeder]

Waiting for reproduction

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[greg-schroeder]

Closing this after multiple failures to reproduce, reopen if you disagree