Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-26] [New architecture] Upgrade react-native-haptic-feedback #35993

Closed
j-piasecki opened this issue Feb 7, 2024 · 18 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@j-piasecki
Copy link
Contributor

We need to upgrade react-native-haptic-feedback in order to use the new architecture in the App.

More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293483457349

@j-piasecki j-piasecki added AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App Weekly KSv2 labels Feb 7, 2024

This comment was marked as outdated.

This comment was marked as resolved.

@roryabraham
Copy link
Contributor

Just an upgrade, not a new lib. Recategorizing...

@roryabraham roryabraham added NewFeature Something to build that is a new item. and removed AutoAssignerAppLibraryReview Auto assign someone to review a new library being added to App labels Feb 7, 2024
Copy link

melvin-bot bot commented Feb 7, 2024

@BartoszGrajdek
Copy link
Contributor

Hey! I'm Bartosz from Software Mansion and I would like to work on this task.

@roryabraham
Copy link
Contributor

@lschurr the only remaining TODO here will be issuing C+ payment for the PR review

@lschurr
Copy link
Contributor

lschurr commented Feb 12, 2024

Thanks @roryabraham - I'll set a payment date once the PR is merged.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 13, 2024
Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@aldo-expensify
Copy link
Contributor

Merged

@roryabraham
Copy link
Contributor

@lschurr we can pay @sobitneupane $500 for their review of #36160 (assuming no regressions)

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 19, 2024
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 19, 2024
@melvin-bot melvin-bot bot changed the title [New architecture] Upgrade react-native-haptic-feedback [HOLD for payment 2024-02-26] [New architecture] Upgrade react-native-haptic-feedback Feb 19, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 19, 2024
Copy link

melvin-bot bot commented Feb 19, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 19, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-26. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 19, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@sobitneupane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@lschurr
Copy link
Contributor

lschurr commented Feb 23, 2024

@sobitneupane
Copy link
Contributor

@lschurr I will request payment on newDot.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 26, 2024
Copy link

melvin-bot bot commented Feb 26, 2024

Payment Summary

Upwork Job

BugZero Checklist (@lschurr)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@lschurr
Copy link
Contributor

lschurr commented Feb 26, 2024

Summary is correct - @sobitneupane will request in NewDot. Closing this one out.

@lschurr lschurr closed this as completed Feb 26, 2024
@JmillsExpensify
Copy link

$500 approved for @sobitneupane based on summary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Development

No branches or pull requests

8 participants