-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-02-26] [New architecture] Upgrade react-native-haptic-feedback
#35993
Comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Just an upgrade, not a new lib. Recategorizing... |
Triggered auto assignment to @lschurr ( |
Hey! I'm Bartosz from Software Mansion and I would like to work on this task. |
@lschurr the only remaining TODO here will be issuing C+ payment for the PR review |
Thanks @roryabraham - I'll set a payment date once the PR is merged. |
Triggered auto assignment to @aldo-expensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Merged |
@lschurr we can pay @sobitneupane $500 for their review of #36160 (assuming no regressions) |
react-native-haptic-feedback
react-native-haptic-feedback
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.42-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-02-26. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Offer sent to @sobitneupane - https://www.upwork.com/nx/wm/offer/101049459 |
@lschurr I will request payment on newDot. |
Payment Summary
BugZero Checklist (@lschurr)
|
Summary is correct - @sobitneupane will request in NewDot. Closing this one out. |
$500 approved for @sobitneupane based on summary. |
We need to upgrade
react-native-haptic-feedback
in order to use the new architecture in the App.More context: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293299589539
Discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1707293483457349
The text was updated successfully, but these errors were encountered: