[Wave Collect] [Ideal Nav] Refactor goBack to simplify the navigation logic

[hayata-suenaga]

Issue

The logic and responsibility of the goBack function grew too much over time.

Solution

Split the goBack function into different functions to ensure it is easy to use and debug in the future

Background

Several regressions occurred from the Ideal Navigation PR, particularly concerning the back navigation behavior. The complexity of the goBack function may be responsible for some of these regressions. @adamgrzybowski has suggested a refactor of this function to prevent similar issues in the future.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hayata-suenaga]

@adamgrzybowski please comment on this issue so that I can assign you to it. 🙇

[adamgrzybowski]

👋

[melvin-bot]

This issue has not been updated in over 15 days. @jliexpensify, @adamgrzybowski, @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hayata-suenaga]

this is a refactoring issue that is complicated. Adam is going to work on it when they have time.

[trjExpensify]

This should minimally be weekly priority though, right?

[hayata-suenaga]

there is a new project dashboard?

[trjExpensify]

Yep, #wave-collect is where the party is at!

[mountiny]

@adamgrzybowski how is this one looking? What are the next steps?

[adamgrzybowski]

@mountiny I need to fix tests for this PR. After that I can focus on the goBack if this is the most urgent thing.

It would be great to have @WojtekBoman around for some brainstorming though. The go back is used in a lot of places and we don't want to miss any use cases. He will be back on Monday (18.03)

I was asked to help with this issue #36476 so maybe I could work on it in the meantime.

[melvin-bot]

This issue has not been updated in over 15 days. @jliexpensify, @adamgrzybowski, @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[jliexpensify]

Moving back to Weekly, how are we going with this one?

[hayata-suenaga]

@adamgrzybowski, let me know your availability and when you're planning to work on this refactor. Depending on when you're planning to work on this, we can adjust the priority back to weekly 😄

[adamgrzybowski]

@hayata-suenaga I think we will take care of that after preparing section for the search tab in the design docs

[melvin-bot]

This issue has not been updated in over 15 days. @jliexpensify, @adamgrzybowski, @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hayata-suenaga]

Melvin -> @hayata-suenaga I think we will take care of that after preparing section for the search tab in the design docs

[hayata-suenaga]

@adamgrzybowski how is search tab project going?

[adamgrzybowski]

Hi! I just got back from vacation, so I'll take a look around and let you know.

[hayata-suenaga]

welcome back! 😄

[melvin-bot]

@jliexpensify, @adamgrzybowski, @hayata-suenaga, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[hayata-suenaga]

Re-opening just to ensure that we get back to this eventually

[jliexpensify]

Hi @adamgrzybowski is this one going to be worked on by any chance? Juat wondering what the priority is. Thanks!

[adamgrzybowski]

This issue has a low priority. We fixed bugs that caused us to think about the refactor. This goBack function isn't pretty but it works. We should think about the refactoring again when we don't have any other tasks but currently have other priorities.

[jliexpensify]

Got it, thanks! @trjExpensify - going off Adam's comment above: did you want to keep this one open, or can I close this issue?

[trjExpensify]

The problem in the OP seems suitably vague, and we've fixed the bugs that came up during the rollout, so I'm good with closing this until we get a more concrete problem for refactoring goBack.