Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page #35764

Closed
1 of 7 tasks
izarutskaya opened this issue Feb 3, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@izarutskaya
Copy link

izarutskaya commented Feb 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Precondition: a few workspaces should be created

  1. Open app
  2. Tap on the "Expensify" icon on top left corner
  3. Tap on any listed workspace
  4. Tap on back button
  5. Tap on Chat tab on bottom nav panel
  6. Tap on Back button
  7. Tap on Settings icon in bottom navigation page
  8. Tap on back button
  9. Tap on Workspace icon on top left corner
  10. Tap on "Expensify"
  11. Tap on any listed workspace

Expected Result:

Step 7 and 11: user should be navigated to the workspace

Actual Result:

Step 7 and 11: user navigated on the workspace overview page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
  • iPad Pro 11" 2020/iPadOS 17.2

Screenshots/Videos

Bug6366118_1706979333594.RPReplay_Final1706941919.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017b82db16dc264309
  • Upwork Job ID: 1753896928387526656
  • Last Price Increase: 2024-02-03
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Feb 3, 2024
Copy link

melvin-bot bot commented Feb 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017b82db16dc264309

@melvin-bot melvin-bot bot changed the title LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page [$500] LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page Feb 3, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 3, 2024
Copy link

melvin-bot bot commented Feb 3, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

Copy link
Contributor

github-actions bot commented Feb 3, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 3, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Feb 3, 2024
Copy link

melvin-bot bot commented Feb 3, 2024

Triggered auto assignment to @thienlnam (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Feb 5, 2024
@mountiny mountiny assigned mountiny and unassigned thienlnam Feb 5, 2024
@mountiny
Copy link
Contributor

mountiny commented Feb 5, 2024

cc @adamgrzybowski Not a blocker, there is a bunch of issues related to ipad specifically, tracking them here https://expensify.slack.com/archives/C036QM0SLJK/p1707137489876029

@jliexpensify
Copy link
Contributor

@mountiny is @adamgrzybowski working on these iPad issues? Should we remove the Help Wanted?

@mountiny mountiny removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 6, 2024
@mountiny
Copy link
Contributor

mountiny commented Feb 6, 2024

Yep this is addressed, thanks!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 13, 2024
@melvin-bot melvin-bot bot changed the title [$500] LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page [HOLD for payment 2024-02-20] [$500] LHN - Unable to navigate to workspace settings from bottom tab and from Workspace listing page Feb 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 13, 2024
Copy link

melvin-bot bot commented Feb 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 13, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
  • [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@allroundexperts] Determine if we should create a regression test for this bug.
  • [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@jliexpensify
Copy link
Contributor

@allroundexperts does the checklist need to be completed here? Thanks!

@mountiny
Copy link
Contributor

No I think we do not need it here

@mountiny
Copy link
Contributor

Additionally, there is nothing to pay here actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

5 participants