Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-13] [$500] [Simplified Collect][Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) #35713

Closed
luacmartins opened this issue Feb 2, 2024 · 33 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Feb 2, 2024

Implement WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) from the Simplified Collect: Profile, Members, Categories design doc

Issue OwnerCurrent Issue Owner: @burczu
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e777c5185b93bdf5
  • Upwork Job ID: 1755659051188183040
  • Last Price Increase: 2024-02-08
@luacmartins luacmartins added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. Engineering NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Feb 2, 2024
@luacmartins luacmartins self-assigned this Feb 2, 2024
Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link

melvin-bot bot commented Feb 2, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 2, 2024
@luacmartins
Copy link
Contributor Author

@burczu can you please comment here so I can assign you to the issue?

@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Feb 2, 2024
@luacmartins luacmartins changed the title WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) [Simplified Collect] [Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) Feb 2, 2024
@luacmartins luacmartins changed the title [Simplified Collect] [Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) [Simplified Collect][Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) Feb 2, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2024
@burczu
Copy link
Contributor

burczu commented Feb 5, 2024

Hi! I'm Bartek from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

Copy link

melvin-bot bot commented Feb 8, 2024

@burczu, @luacmartins, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Feb 8, 2024
@laurenreidexpensify
Copy link
Contributor

@burczu is there a draft PR up for this yet?

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e777c5185b93bdf5

@melvin-bot melvin-bot bot changed the title [Simplified Collect][Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) [$500] [Simplified Collect][Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) Feb 8, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 8, 2024
@luacmartins
Copy link
Contributor Author

Cool, I'll do a full review and also ask C+ to review it today so we can speed things up.

@luacmartins
Copy link
Contributor Author

luacmartins commented Feb 27, 2024

@aimane-chnaif are you available to review this PR today?

@aimane-chnaif
Copy link
Contributor

@aimane-chnaif are you available to review this PR today?

yes. should I start while it's in draft state?

@aimane-chnaif
Copy link
Contributor

aimane-chnaif commented Feb 27, 2024

I see that the PR is trying to fix other unrelated bugs.

@burczu can you please answer to #37109 (comment)?
#37113 (review)

@luacmartins
Copy link
Contributor Author

yes. should I start while it's in draft state?

yes, that's fine. The PR should be ready, it's just in draft while we wait on internal review.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 28, 2024
@burczu
Copy link
Contributor

burczu commented Feb 28, 2024

@luacmartins @aimane-chnaif Just to inform - the PR is now published.

@burczu
Copy link
Contributor

burczu commented Feb 28, 2024

I see that the PR is trying to fix other unrelated bugs.

@burczu can you please answer to #37109 (comment)? #37113 (review)

@aimane-chnaif Answered

Copy link

melvin-bot bot commented Feb 29, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 5, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 5, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@aimane-chnaif
Copy link
Contributor

False alarm ^

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 6, 2024
@melvin-bot melvin-bot bot changed the title [$500] [Simplified Collect][Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) [HOLD for payment 2024-03-13] [$500] [Simplified Collect][Members] WorkspaceMembersPage: Bulk actions (invite, remove, make admin, make member) Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 6, 2024
Copy link

melvin-bot bot commented Mar 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

  • @burczu does not require payment (Contractor)
  • @aimane-chnaif requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Mar 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@aimane-chnaif] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@laurenreidexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 13, 2024
Copy link

melvin-bot bot commented Mar 13, 2024

Payment Summary

Upwork Job

  • Contributor: @burczu is from an agency-contributor and not due payment
  • ROLE: @aimane-chnaif paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@laurenreidexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1755659051188183040/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@laurenreidexpensify
Copy link
Contributor

Payment Summary
Upwork Job

Contributor: @burczu is from an agency-contributor and not due payment
ROLE: @aimane-chnaif $(500) offer sent via Upwork (LINK)

@laurenreidexpensify
Copy link
Contributor

Payment Summary
Upwork Job

Contributor: @burczu is from an agency-contributor and not due payment
ROLE: @aimane-chnaif $(500) paid in Upwork

@laurenreidexpensify
Copy link
Contributor

@luacmartins no regression test here needed right? if so feel free to close thanks!

@luacmartins
Copy link
Contributor Author

Yea, we'll add these once the feature is fully implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

6 participants