Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen #35703

Closed
6 tasks done
lanitochka17 opened this issue Feb 2, 2024 · 8 comments
Closed
6 tasks done
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): shussain@applausemail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go the the Account settings > About > View keyboard shortcuts
  2. Press back button

Expected Result:

Keyboard shortcuts modal should be closed and blank screen should not be displayed

Actual Result:

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365214_1706900698860.2024-02-02_22-18-46.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@johnmlee101
Copy link
Contributor

Able to reproduce

@allgandalf
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

What is the root cause of that problem?

OnBackButtonPress is missing in keyboardShortcutsPage

What changes do you think we should make in order to solve the problem?

Pass the prop onBackButtonPress={() => Navigation.goBack()} in HeaderWithBackButton

<HeaderWithBackButton title={translate('keyboardShortcutsPage.title')} />

What alternative solutions did you explore? (Optional)

N/A

@allgandalf
Copy link
Contributor

I think this is not a deployBlock but rather a regression from #29063

Here is the regression commit

@shubham1206agra
Copy link
Contributor

@hayata-suenaga This looks like related to goBack problems with Ideal Nav. Can you check this too?

@Krishna2323
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Pressing the back button on the "Keyboard Shortcuts" page leads to a blank screen

What is the root cause of that problem?

We haven't added onBackButtonPress prop to HeaderWithBackButton in KeyboardShortcutsPage. We should add onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)} just like we do in AboutPage

<HeaderWithBackButton title={translate('keyboardShortcutsPage.title')} />

What changes do you think we should make in order to solve the problem?

Add onBackButtonPress={() => Navigation.goBack(ROUTES.SETTINGS)} to HeaderWithBackButton in KeyboardShortcutsPage.

Result

@hayata-suenaga
Copy link
Contributor

Closing this issue to combine it with the existing issue.

@hayata-suenaga hayata-suenaga removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants