Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sections - Cards on the right hand page are left aligned instead of centered #35688

Closed
2 of 6 tasks
lanitochka17 opened this issue Feb 2, 2024 · 8 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go to Settings from the top
  2. Go to Wallet
  3. Go to Share code
  4. Go to Settings from the bottom
  5. Go to any workspace
  6. Go to Bills, Reimbursements etc

Expected Result:

The cards on the right hand page are centered

Actual Result:

The cards on the right hand page are left aligned

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365111_1706895548818.20240203_013630.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 2, 2024

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@bondydaa
Copy link
Contributor

bondydaa commented Feb 2, 2024

hmm @Expensify/design anyone familiar with recent changes for these types of elements? Even if not can you help confirm how they should look? I'm guessing centered aligned?

@bondydaa
Copy link
Contributor

bondydaa commented Feb 2, 2024

if I had to guess it might be from this big PR https://github.com/Expensify/App/pull/33280/files#diff-701113bd02bdc9f8c671df93b0a5a0d2dadb520ae378674c8cfa956d1eb2daff but I only say that b/c I see it touches a lot of styles (I haven't looked through all PRs from the deploy checklist either).

@s77rt
Copy link
Contributor

s77rt commented Feb 2, 2024

I think this is by design not a bug

@bondydaa
Copy link
Contributor

bondydaa commented Feb 2, 2024

i could see that too 😁 do you have a GH or anything where we made that decision?

@shawnborton
Copy link
Contributor

Correct, not a bug! This is part of the #ideal-nav design doc

@francoisl francoisl removed the DeployBlockerCash This issue or pull request should block deployment label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants