[HOLD for payment 2023-12-04] Investigate Navigation.goBack issue on page reload

[luacmartins]

Action Performed:

1. Click on FAB > Start chat
2. Click on 'Request money, get $250' to go to the referral page
3. Reload the page
4. Click on the 'Got it' Button
5. Notice that it navigates you back to the same page

Expected Result:

User should be navigated to the fallback route

Actual Result:

User is navigated back to the same page, but clicking Got it a 2nd time navigates the user to the correct fallback page

Workaround:

Click Got it twice

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mov

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[rojiphil]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When the current route is a RHP referral page and the application is reloaded, user is navigated back to the same page on click of Back button or Got it.

What is the root cause of that problem?

When we reload the application, the application will launch the app with deep link url here. Here we wait for the routes to be populated in navigation here and, later, perform navigation here using PUSH. As we are additionally pushing the route, there will be two route entries for RHP page as shown below. This is the root cause for the user to be navigated back to the same page.

The same behaviour can be observed for Start chat RHP page.

Additionally, desktop applications have problem for deep link URL due to the additional call to navigate function. I have also added a proposal there

What changes do you think we should make in order to solve the problem?

To solve the problem, we can simply remove the call to navigate function here

- Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.PUSH);

What alternative solutions did you explore? (Optional)

The alternate approach used was to replace PUSH with REPLACE like this.

Navigation.navigate(route, CONST.NAVIGATION.ACTION_TYPE.REPLACE);

[abdulrahuman5196]

This issue should be solved by this PR - #31702

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 31688 Notification preferences page appears again after refreshing the page #31702

If no regressions arise, payment will be issued on 2023-12-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

I think we can close this one, since we have another issue to solve this.