Deploy Checklist: New Expensify 2023-11-20

[os-botify]

Release Version: 1.4.1-13
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Unnecessary blank area is created when scrolling down while keyboard is open #19642 #21298
• Updated logic to handle unread messages case #25935
• [No QA][TS migration] Migrate 'CheckForPreviousReportActionID.js' lib to TypeScript #27652
• Add join and leave to user created rooms #28408
• Update Free-Trial.md #28662
• Fix/28342: Task description does not remove empty quotes #29144
• Add ReportHeaderSkeletonView to ReportScreen #30367
• Feature : Added Promote referral program messaging to OptionsSelector component #30372
• [Form Provider Refactor] AdditionalDetailsStep and AddressForm #30568
• chore(node): bump node version to 20.9.0 #30645
• fix: 30380 Tag - Unable to unselect tag from created expense when the tag is disabled #30672
• fix: Start Chat - Invalid red dot briefly appears by closing 'room' tab when there's no prior action #30679
• Fix Update regex for masked accountNumber #30813
• format request display amount on submit #30873
• Fix copy invite room message #30898
• [TS migration] Migrate 'FormElement.js' component to TypeScript #31012
• Fix/29829: Admin cannot replace receipt #31024
• [No QA] Automated theme hook migration #31034
• Add redirect for distance requests article #31036
• App should navigate back to current chat report after closing status modal #31051
• Migrate LHNOptionsList to Flashlist #31052
• Fix: Tags under "All" section displayed not in alphabetic order #31129
• fix: ensure pusher events are processed in the same order they were received #31144
• fix: Distance - reset map boundaries on resize #31156
• Fix/30378: Update correct pendingFields #31172
• Fix: Cannot navigate to Address page by deeplink #31174
• fix: double tap on currency selects AFN #31225
• Fix scrolling down on edit composer scroll up the page #31271
• Fall back to login as display name when we have it #31275
• Bump Onyx to 1.0.117 #31297
• Fix: Inconsistency of currency decimal format #31299
• fix: redirect to parent chat when creating a task #31307
• Create Business-Bank-Accounts-USD.md #31311
• 27168 Deeplinking not working after logout #31316
• Update and rename Business-Bank-Accounts-USD.md to Connect-a-Bank-Acc… #31325
• Hide mention of new user in offline mode #31342
• Bump expensify-common to not allow starting and ending hyphen in local-style urls #31346
• Update redirects Matt Mo's HelpDot Articles #31355
• [HelpDot] Updates to HelpDot #31398
• Fix: Avatars row position is not correct on Add message page #31399
• Create Profile.md #31408
• Update Auto-Reconciliation.md to add images #31409
• Remove infra as a code owner of the redirects file #31410
• Fix category is reset after refreshing #31423
• fix: MultipleAvatars negative margin #31430
• Follow up: Fix dependency cycle issue #31438
• Fix settings page skeleton isn't shown #31450
• Update Direct-Bank-Connections.md #31453
• [No QA] Fix too-big checklists #31458
• [No QA] Attempt repack once before giving up #31459
• [No QA] chore(node): bump version to 20.9.0 #31460
• Prevent highlight when long pressing text link #31465
• fix image not downloading in offline mode #31474
• [TS migration] Migrate 'ExpensifyWordmark.js' component to TypeScript #31478
• Fix redundant key console warnings #31484
• Replacing the 'import from spreadsheet' screenshot for an article #31497
• [No QA] Use Node 20 for all JavaScript GitHub Actions #31501
• [No QA] Update deployBlocker workflow to stop using community actions #31505
• [No QA] Improve GitUtils logging #31507
• [No QA] Fix deploy blocker workflow #31514
• fix: Receipt - The border green line on top and bottom in native. #31519
• [CP Staging] Prevent infinite spinner in transition page #31522
• [NO QA] Revert PR 30679 #31547
• [NoQA] Use specific commit for the setup osbotify action #31550
• [No QA] Inherit secrets to createChecklist job #31553
• [NoQA] Fix the path to the action #31555
• fix link to the referral program details #31574
• Revert https://github.com/Expensify/App/pull/21298 #31601
• [NO QA] Revert "Migrate LHNOptionsList to Flashlist" #31642
• [CP Stag] fix: 31623 Unread message green line marker remains after opening the new message #31653
• [CP Stag] Add fallback routes to Referral page #31658
• Set displayName fallback for group chat members page #31659
• [CP Staging] Fix notification click through #31663

Deploy Blockers:

• [HOLD for payment 2023-11-30] [$500] Request money - Hmm it's not here page opens when click on Learn more via the banner below #31567
• Connect bank account - Can't enter/correct the date manually in Company information page #31572
• [HOLD for Payment 2023-12-04] Request money - Two options are highlighted after opening tag label second time #31578
• [HOLD for payment 2023-11-30] mWeb/Safari - Chat - The top part of the UI is enlarged when posting bold text #31580
• [HOLD for payment 2023-12-04] Login - Background color of chat list is different from the header in LHN when it is loading #31581
• [$500] Desktop - Reload - ''Hmm... it's not here'' when reloading the desktop app #31592
• [HOLD for payment 2023-12-04] [HOLD for payment 2023-11-30] [$500] iOS - LHN - Skeleton appears instead of LHN if user go offline #31610
• [HOLD for payment 2023-12-28] [$500] BA - Personal information / Beneficial Form entered offline isn't saved after returning online #31612
• [$500] iOS - Conversation - Green line between the first and second new messages when returning online #31617
• [Paid] [$500] Chat - Unread message green line marker remains after opening the new message #31623
• [HOLD for payment 2023-11-30] Notification - User is navigated to LHN after opening notification when app is closed #31625
• [$500] [HOLD for payment 2023-11-30] Web - Referral - 'Got it' button does not take you back to the Previous page after a reload #31628
• IOU - Chat row with a red dot in LHN is not grayed out when money request fails #31639
• [HOLD for payment 2023-11-30] Web - Chat creation - App crashes when creating group with new user and clicking on members #31654

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[melvin-bot]

📣 @os-botify[bot]! 📣
Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
Instructions here to join the channel 📖

[os-botify]

Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.1-4 🚀

[roryabraham]

#31570 is expected behavior, checking it off

edit: it's not here right now due to some bugs with our CI this morning. I'll use our new tool to refresh the checklist.

[luacmartins]

Checking off #31567 since we CPed a fix

[mvtglobally]

Regression is 65% complete

PR #30568 is failing with #31570
PR #30679 is failing with #31583. Repro in prod Checking off
PR #31519 is failing with #30284. Reproducible in PrOD, checking off

[luacmartins]

Checking off #31581. Demoted to NAB

[luacmartins]

Checking off #31580. We reverted the offending PR.

[mvtglobally]

Regression is 5% left

PR #30568 is failing with #31570
PR #30898 is failing with #31568. Repro in prod, checking off
#31036 PROD QA. Are we ok to check off?
#31398 PROD QA. Are we ok to check off?
PR #31465 is failing with #31597 Repro in prod, checking off
PR #31522 seems to be still failing with #31595

[Julesssss]

I manually added #31610 as a blocker as the CI seemed to fail

[kbecciv]

Regression is 1% left

PR #30568 is failing with #31570
#31036 and #31398 PROD QA. Are we ok to check off?
PR #31522 is failing with #31595, repro in prod, check off

Open blockers:
#31578
#31592
#31610
#31612

[rlinoz]

Manually added #31617 as a blocker

[kbecciv]

Regression is completed!

PR #30568 is failing with #31570, issue closed. Are we ok to check off?
#31036 and #31398 PROD QA. Are we ok to check off?
PR #31522 is failing with #31595, repro in prod, check off

Open blockers:
#31578
#31592
#31610
#31612
#31617

[amyevans]

Checking off #31580 after CP

Edit: Looks like Carlos already checked it off 😄

[rlinoz]

Checking off #31617, although it is a bug it is not a blocker.

[luacmartins]

Checking off #31610 and #31581 since we're CPing a revert.

[Julesssss]

Checking off #31610 as we reverted and CPd the PR that introduced the issue.

[luacmartins]

Checking off #31592. The issue exists in previous versions.

[kbecciv]

PR #30568 is failing with #31570, issue closed. Are we ok to check off?
#31036 and #31398 PROD QA. Are we ok to check off?

Open blockers:
#31578
#31612
#31623
#31625
#31628
#31639
#31654

[luacmartins]

Checking off #31623 since we CPed a fix

[luacmartins]

Checking off #31612. Demoted to NAB since that's an issue with all form providers and we have a PR with a fix.

[luacmartins]

Checking off #31639. Demoted to NAB.

[luacmartins]

Checking off #31628. CPed a fix

[luacmartins]

Checking off #31654. We CPed a fix.

[luacmartins]

Checking off #31036. Prod QA.

[luacmartins]

Checking off #31398. HelpDot copy changes

[luacmartins]

Checking off #31658. Tested in staging and it works.

[luacmartins]

Checking off #31578. Demoted to NAB.

[luacmartins]

Checking off #31659. Tested in staging and it's a pass

[luacmartins]

Checking off #31625. We CPed a fix.

[luacmartins]

Down to the last CP now before we can deploy

[luacmartins]

Checking off #31663. Tested on staging and it works!

[luacmartins]

Checklist is clear. Kicking off the deploy.

[luacmartins]