[HOLD for payment 2023-10-31] [HOLD for payment 2023-10-30] [$500] Concierge not highlights on login

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: Dev 1.3.87.0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697780051399049

Action Performed:

1. logout if you already logged in
2. enter email and magic code

Expected Result:

Concierge should be highlights in LHN and should show chats

Actual Result:

Concierge not highlights

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Screen_Recording_20231020_112258_New.Expensify.Dev.mp4

Android: mWeb Chrome

Screen_Recording_20231020_111801_Chrome.mp4

iOS: Native

RPReplay_Final1697781288.MP4

iOS: mWeb Safari

RPReplay_Final1697780959.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-20.at.11.04.30.AM.mov

MacOS: Desktop

Screen.Recording.2023-10-20.at.11.08.13.AM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a2ea61367ef9c991
• Upwork Job ID: 1715357740561367040
• Last Price Increase: 2023-10-20

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a2ea61367ef9c991

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ntdiary (External)

[spectreintegrated]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Concierge should be highlighted/selected after login

What is the root cause of that problem?

currentReportID is empty in OptionRowLHNDataWithFocus and thus doesn't highlight. It also gets cleared when clicking the "back" arrow to go back to LHN. Not sure if that is intentional.

What changes do you think we should make in order to solve the problem?

if currentReportID is empty choose first item in list. If it being cleared by navigation is not intentional should last id be highlighted or just select top item?

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @spectreintegrated! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[spectreintegrated]

Contributor details
Your Expensify account email: info@spctr.ltd
Upwork Profile Link: https://www.upwork.com/freelancers/~01e0f115879dbdd44f

[melvin-bot]

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

[bernhardoj]

Regression from #29268

We should return an empty string if none of the if conditions is fulfilled

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.js

Lines 17 to 36 in 115974e

	const getTopMostReportIDFromRHP = (state) => {
	if (!state) {
	return;
	}
	const topmostRightPane = lodashFindLast(state.routes, (route) => route.name === NAVIGATORS.RIGHT_MODAL_NAVIGATOR);
	if (topmostRightPane) {
	return getTopMostReportIDFromRHP(topmostRightPane.state);
	}
	const topmostRoute = lodashFindLast(state.routes);
	if (topmostRoute.state) {
	return getTopMostReportIDFromRHP(topmostRoute.state);
	}
	if (topmostRoute.params && topmostRoute.params.reportID) {
	return topmostRoute.params.reportID;
	}
	};

or the state is empty.

App/src/libs/Navigation/AppNavigator/createCustomStackNavigator/CustomRouter.js

Lines 18 to 20 in 115974e

	if (!state) {
	return;
	}

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

@bernhardoj's solution looks good. I went ahead and created a PR since we might CP it this weekend to fix it before Money2020 on Monday. We should compensate @bernhardoj accordingly.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix concierge chat highlight #30145

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.89-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix concierge chat highlight #30145

If no regressions arise, payment will be issued on 2023-10-31. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @gadhiyamanan requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@luacmartins] The PR that introduced the bug has been identified. Link to the PR:
• [@luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@luacmartins] Determine if we should create a regression test for this bug.
• [@luacmartins] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

payment upcoming!

[dylanexpensify]

tomorrow, tomorrow, and tomorrow

[melvin-bot]

@luacmartins, @dylanexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

just pending payment

[dylanexpensify]

@bernhardoj mind applying: https://www.upwork.com/jobs/~01a2ea61367ef9c991 🙇‍♂️

[bernhardoj]

Applied

[dylanexpensify]

offer sent!

[dylanexpensify]

done!

[gadhiyamanan]

@dylanexpensify reporting bonus is pending

[gadhiyamanan]

Payment done for this issue, thanks!