[HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.3.85-0
Reproducible in staging?: Yes
Reproducible in production?: Unknown
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @kevinksullivan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697492929166339

Action Performed:

User A:

1. Select Request money
2. User A: enter User B as the person you're requesting from

User B:

1. Login
2. Navigate to the IOU report
3. Select Pay with Expensify
4. Select Bank account
5. Add a personal bank account

Expected Result:

The user should land on the Additional details page to continue the Wallet enablement flow, which asks them for personal information.

Actual Result:

The user lands on the wallet page , and has to go back and select Pay again.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Note: the first screen shows the prompt to add a bank account or debit card when selecting Pay with Expensify , and the second screenshot shows where you're brought after adding the account.

bank.Account.wallet.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[MariaHCD]

@getusha has offered to take a look at this one! 🙏🏼

https://expensify.slack.com/archives/C01GTK53T8Q/p1697547375338189?thread_ts=1697033275.944009&cid=C01GTK53T8Q

[getusha]

@MariaHCD facing this error, is this something known?

[MariaHCD]

Ah, yes, we throttle users when adding bank accounts via Plaid 😅 I think testing with another account will work.

[MariaHCD]

Do let me know if there is overlap with https://github.com/Expensify/App/pull/29573/files#diff-186ee6dd4f2074460e09890d51b9ef7ef11bc902c32e472b58b76a060a3e4d63R367

[abdulrahuman5196]

Kindly assign me this GH for C+ review.

[melvin-bot]

Triggered auto assignment to @Li357, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.87-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: navigate to enable-payment page after adding Bank account #29847

If no regressions arise, payment will be issued on 2023-10-27. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @abdulrahuman5196 requires payment
• @getusha requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@abdulrahuman5196] The PR that introduced the bug has been identified. Link to the PR:
• [@abdulrahuman5196] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@abdulrahuman5196] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@abdulrahuman5196] Determine if we should create a regression test for this bug.
• [@abdulrahuman5196] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[bfitzexpensify]

Offers sent @abdulrahuman5196 @getusha.

Also a reminder to complete the BZ checklist @abdulrahuman5196 - thank you!

[getusha]

@bfitzexpensify Accepted thanks!

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression but a new expectation.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Navigate to the IOU report
2. Select Pay with Expensify
3. Select Bank account
4. Add a personal bank account
5. Choose account from drop down menu and click Save & continue > Continue
6. Verify that Additional details page is opened.

@bfitzexpensify Accepted the offer and checklist complete.

[bfitzexpensify]

Great, those steps look good to me. I opened https://github.com/Expensify/Expensify/issues/330782 for the regression test.

All payments complete, we're all done here - thanks everyone!