[$500] [HOLD for payment 2023-10-24] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] LHN - Split bill description having line breaks is not truncated in LHN

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.3.84.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697385230621939

Action Performed:

1. Make a new group chat.
2. Click on split bill
3. In the description, enter characters with multiple line breaks in between (using shift + enter)

Expected Result:

The description should be truncated in LHN

Actual Result:

The description is not truncated in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen_Recording_20231016_094335_Chrome.mp4

iOS: Native

iOS: mWeb Safari

RPReplay_Final1697464542.1.MP4

MacOS: Chrome / Safari

Screen.Recording.2023-10-15.at.9.20.56.PM.mov

Recording.5006.mp4

MacOS: Desktop

Recording.545.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0103feec7f2a1def39
• Upwork Job ID: 1716836279877980160
• Last Price Increase: 2023-10-24

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Proposal by: @esh-g
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697385230621939

Proposal

Please re-state the problem

Split bill description having line breaks is not truncated in LHN

What is the root cause of the problem?

The root cause is that we are using styles.pre in OptionRowLHN.js:

App/src/components/LHNOptionsList/OptionRowLHN.js

Line 102 in 5ec2e8a

: [textStyle, styles.optionAlternateText, styles.pre, styles.textLabelSupporting],

This change was made in this PR: #27822
At the PR time, split bill description alternate text was broken (like it is now on prod) so it wasn't tested for it.

What changes should be made to fix this?

In the fore-mentioned PR, a similar problem was occurring and it was fixed by adding the ReportUtils.formatReportLastMessageText here:

App/src/libs/OptionsListUtils.js

Lines 379 to 380 in 5ec2e8a

	const properSchemaForModifiedExpenseMessage = ReportUtils.getModifiedExpenseMessage(lastReportAction);
	lastMessageTextFromReport = ReportUtils.formatReportLastMessageText(properSchemaForModifiedExpenseMessage, true);

So, we can follow a similar approach and change the MoneyRequestAction condition here:

App/src/libs/OptionsListUtils.js

Lines 366 to 367 in 5ec2e8a

	} else if (ReportActionUtils.isMoneyRequestAction(lastReportAction)) {
	lastMessageTextFromReport = ReportUtils.getReportPreviewMessage(report, lastReportAction, true);

to the following:

const properSchemaForMoneyRequestMessage = ReportUtils.getReportPreviewMessage(report, lastReportAction, true);
lastMessageTextFromReport = ReportUtils.formatReportLastMessageText(properSchemaForMoneyRequestMessage);

this would also match the backend which currently returns only the first line before the line break for the last message text

What alternate approach did you explore?

This is actually a big change in the whole approach of handling the formatting of lastMessageText.

Currently we are formatting the ReportUtils.formatReportLastMessageText() very randomly. While adding comments, we use this function to set the lastMessageText property on the report itself, but for things like Modified expense action we are using it in OptoinsListUtils.getLastMessageTextForReport to just display it in LHN.
Moreover, the backend also seems to perform formatting like removing the text after one line break.

What can be done is that all the logic for the line break formatting can be removed from backend as well as while creating optimistic reports and just keep it exclusively in OptionsUtils.getLastMessageTextForReport and apply the ReportUtils.formatReportLastMessageText for every message.

Additionally,
We can copy whatsApp by replacing every line break with whitespace in the ReportUtils.formatReportLastMessageText method by refactoring it like this:

function formatReportLastMessageText(lastMessageText,) {
    return String(lastMessageText).trim().replace(CONST.REGEX.LINE_BREAK, ' ').substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();
}

this would remove the need to have the "hacky" logic we use for modified expense currently:

App/src/libs/ReportUtils.js

Lines 927 to 932 in 5ec2e8a

	function formatReportLastMessageText(lastMessageText, isModifiedExpenseMessage = false) {
	if (isModifiedExpenseMessage) {
	return String(lastMessageText).trim().replace(CONST.REGEX.LINE_BREAK, '').trim();
	}
	return String(lastMessageText).trim().replace(CONST.REGEX.AFTER_FIRST_LINE_BREAK, '').substring(0, CONST.REPORT.LAST_MESSAGE_TEXT_MAX_LENGTH).trim();
	}

[francoisl]

@esh-g your solution works, are you available to send a PR for it?

[melvin-bot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[flodnv]

Thanks for handling this @francoisl, leaving this in your hands

[esh-g]

@francoisl Yes, I'm available just doing so in 10 min

[esh-g]

@francoisl PR is here: #29693 🚀

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Format line breaks in split bill description #29693

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @esh-g requires payment
• @esh-g requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@esh-g] Determine if we should create a regression test for this bug.
• [@esh-g] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Format line breaks in split bill description #29693

If no regressions arise, payment will be issued on 2023-10-24. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @esh-g requires payment
• @esh-g requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR:
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@esh-g] Determine if we should create a regression test for this bug.
• [@esh-g] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@NicMendonca] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0103feec7f2a1def39

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[NicMendonca]

@esh-g can you please apply to the job in Upwork? https://www.upwork.com/jobs/~0103feec7f2a1def39

[esh-g]

@NicMendonca Applied to the job!

[esh-g]

@NicMendonca This is my profile: https://www.upwork.com/freelancers/~0186b1d7cc69656f22

[NicMendonca]

offer sent!

[NicMendonca]

@esh-g paid! 🎉

[esh-g]

@NicMendonca This PR was merged within the bonus period... please also consider the speed bonus..

[esh-g]

@NicMendonca the PR was merged between the bonus period... please reconsider the bonus