Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EmojiTest's it('should put a less frequent and recent used emoji behind' test to not be flakey #29672

Closed
Beamanator opened this issue Oct 16, 2023 · 3 comments
Closed

Update EmojiTest's it('should put a less frequent and recent used emoji behind' test to not be flakey #29672

Beamanator opened this issue Oct 16, 2023 · 3 comments
Assignees
@Beamanator
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@Beamanator
Copy link
Contributor

Beamanator commented Oct 16, 2023 •
edited by melvin-bot bot
Loading

This test failed here: https://github.com/Expensify/App/actions/runs/6533171700/job/17737811302

And the only failure was that the lastUpdatedAt timestamp was off by 1 ms.

Let's update the test so we don't test time diffs, so this test should never fail incorrectly

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017418578e73d69510
  • Upwork Job ID: 1713893437548019712
  • Last Price Increase: 2023-10-16
@Beamanator Beamanator added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Oct 16, 2023
@Beamanator Beamanator self-assigned this Oct 16, 2023
@Beamanator Beamanator mentioned this issue Oct 16, 2023
Merged
58 tasks
@melvin-bot melvin-bot bot added the Overdue label Oct 24, 2023
@Beamanator
Copy link
Contributor Author

meh maybe later

@melvin-bot melvin-bot bot removed the Overdue label Oct 26, 2023
@Beamanator Beamanator added Hourly KSv2 Weekly KSv2 Monthly KSv2 and removed Hourly KSv2 Weekly KSv2 labels Oct 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 27, 2023
@Beamanator
Copy link
Contributor Author

not prioritizing

@melvin-bot melvin-bot bot removed the Overdue label Nov 27, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 28, 2023
@Beamanator
Copy link
Contributor Author

Closing b/c I haven't seen this in a while

@melvin-bot melvin-bot bot removed the Overdue label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Beamanator Beamanator

Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Beamanator