-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-30] [$250] IOU - Text under "category" header is not displayed #28952
Comments
Triggered auto assignment to @isabelastisser ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.Text under category header is not displayed What is the root cause of that problem?We are missing the text on the What changes do you think we should make in order to solve the problem?We should add the text to |
ProposalPlease re-state the problem that we are trying to solve in this issue.Text under "category" header is not displayed What is the root cause of that problem?Let's see the Tag Page (MoneyRequestTagPage Component), we are displaying the subtitle But in the Edit Tag page (EditRequestTagPage Component), Category Page and Edit Category Page, we don't have logic to display the subtitle. What changes do you think we should make in order to solve the problem?
Then add the subtitle to Category Page and Edit Category Page like we did with Tag feature above What alternative solutions did you explore? (Optional) |
Triggered auto assignment to @greg-schroeder ( |
Isa is OOO, manually reassigning to move forward while she's offline |
Job added to Upwork: https://www.upwork.com/jobs/~01298a914a67495601 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel ( |
@greg-schroeder, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Upwork job price has been updated to $250 |
@greg-schroeder I'll take this over from you. Looks like this was just an oversight when we implemented the page. I'm going to reduce this to a $250 issue. @DylanDylann if you are still down for it, your solution seems to make sense to me. But let's wait for @Santhosh-Sellavel to weigh in as well. |
Yes, @DylanDylann's Proposal looks good to me! @puneetlath But How to test tags? |
Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new. |
I am assigned as reviewer in PR. |
@puneetlath I'm confused too, why did I get unassigned here? |
@Santhosh-Sellavel my bad, must've done that on accident. I've re-assigned you. |
📣 @Santhosh-Sellavel Please request via NewDot manual requests for the Contributor role ($250) |
Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:
On to the next one 🚀 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-30. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@Santhosh-Sellavel friendly reminder on the checklist so we can pay 😄 |
@puneetlath, @Santhosh-Sellavel, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@Santhosh-Sellavel just waiting on the checklist. |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
@puneetlath Let me know if you differ on any of the above, thanks! |
Payment summary:
@Santhosh-Sellavel please go ahead and request payment on NewDot. |
$250 payment approved for @Santhosh-Sellavel based on comment above. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Go to https://staging.new.expensify.com/
Tap on Workspace chat
Tap plus icon
Tap request money
Enter an amount
Tap next
Tap show more
Tap categories
Expected Result:
In the header " category" , the text "Select a category to help organize your money, or we’ll auto-categorize it for you” must be displayed
Actual Result:
In the header " category" , the text "Select a category to help organize your money, or we’ll auto-categorize it for you” is not displayed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.78-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6226344_1696531344558.header_text.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: