[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open #28926

kbecciv · 2023-10-05T15:02:13Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app
Open any report and focus on composer
Open settings->about->app download links
Right click on any download link and click copy
Start typing anything and observe that app writes everything in composer even though RHN is open

Expected Result:

App should not focus back on composer if RHN is open

Actual Result:

App focuses back on composer even if RHN is open on copy link from app download link in about settings

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.78.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

mac.chrome.desktop.composer.refocus.on.open.RHN.mov

windows.chrome.composer.focus.copy.link.about.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696495147575079

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01a7a9e4d7988e32e2
Upwork Job ID: 1709947117056393216
Last Price Increase: 2023-10-05
Automatic offers:

dukenv0307 | Contributor | 27123533
dhanashree-sawant | Reporter | 27123535

melvin-bot · 2023-10-05T15:02:19Z

Job added to Upwork: https://www.upwork.com/jobs/~01a7a9e4d7988e32e2

melvin-bot · 2023-10-05T15:02:19Z

Triggered auto assignment to @peterdbarkerUK (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-05T15:02:21Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

melvin-bot · 2023-10-05T15:02:25Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

martin12345678900 · 2023-10-05T15:30:12Z

Can't reproduce :/

dukenv0307 · 2023-10-05T15:40:03Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

App focuses back on composer even if RHN is open on copy link from app download link in about settings

What is the root cause of that problem?

In here, after copying the link, we're always refocusing on the composer, even in the case where another route is open.

What changes do you think we should make in order to solve the problem?

In there, we should check that the active route is the report route, if yes we trigger the refocusing. For example, we can do something like this

if (!Navigation.isActiveRoute(ROUTES.REPORT_WITH_ID.getRoute(Navigation.getTopmostReportId()))) {
    return;
}

(This can be checked here or inside ReportActionComposeFocusManager.focus, where it will take effect for all attempts to focus the composers)

What alternative solutions did you explore? (Optional)

This might happen for other opened context menu as well, we should double check and fix the same for those places.
If we decide to add the check in ReportActionComposeFocusManager.focus then it will work for all places.

chahedmoetaz · 2023-10-05T17:11:27Z

Any updates?

melvin-bot · 2023-10-05T17:11:30Z

📣 @chahedmoetaz! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

suneox · 2023-10-05T17:25:42Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - App refocuses on composer even when RHN is open

What is the root cause of that problem?

After press copy a link from context menu item the current implement alway focus to composer at

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Lines 153 to 156 in 7bd5233

    
           onPress: (closePopover, {selection}) => { 
        
               Clipboard.setString(selection); 
        
               hideContextMenu(true, ReportActionComposeFocusManager.focus); 
        
           },

What changes do you think we should make in order to solve the problem?

The focus behavior should be handle base on a use case.
For example, at the report page we have 2 links that can be copied. The first link after copy should be focus and the second link after copy shouldn't focus on the composer so we should handle a focus behavior when executing the function showContextMenu

at BaseReportActionContextMenu.js we have to add variable isFocusComposeAfterSelect into payload after user action on ContextMenuItem

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.js

Line 167 in 7bd5233

    
           onPress={() => interceptAnonymousUser(() => contextAction.onPress(closePopup, payload), contextAction.isAnonymousAction)}

    const payload = {
        reportAction,
        reportID: props.reportID,
        draftMessage: props.draftMessage,
        selection: props.selection,
+       isFocusComposeAfterSelect: props.isFocusComposeAfterSelect,
        close: () => setShouldKeepOpen(false),
        openContextMenu: () => setShouldKeepOpen(true),
        interceptAnonymousUser,
    };

The we have to add config isFocusCompose into PopoverReportActionContextMenu.js the same with isUnreadChat with default value is true to avoid affect current implement

        .....
        const [isChatPinned, setIsChatPinned] = useState(false);
+       const [isFocusComposeAfterSelect, setIsFocusComposeAfterSelect] = useState(false);
        .....
        * @param {Boolean} isUnreadChat - Flag to check if the chat is unread in the LHN. Used for the Mark as Read/Unread action
+       * @param {Boolean} isFocusCompose - Flag to check auto focus compose after action press

        isUnreadChat = false,
+       isFocusCompose = true,
        .....
        setHasUnreadMessages(isUnreadChat);
+       setIsFocusComposeAfterSelect(isFocusCompose);
        .....
        isUnreadChat={hasUnreadMessages}
+       isFocusComposeAfterSelect={isFocusComposeAfterSelect}

After that we config isFocusCompose for ReportActionContextMenu.js also the same with isUnreadChat with default value is true to avoid affect current implement
Then we can use the config for ContextMenuActions on press

      onPress: (closePopover, {selection, isFocusComposeAfterSelect}) => {
          console.log(`___________ isFocusComposeAfterSelect ___________`,isFocusComposeAfterSelect)
          Clipboard.setString(selection);
          hideContextMenu(true, isFocusComposeAfterSelect ? ReportActionComposeFocusManager.focus : undefined);
      },

Finally at page AppDownloadLinks.js we can handle composer focus behavior at

App/src/pages/settings/AppDownloadLinks.js

Line 68 in 7bd5233

    
           onSecondaryInteraction={(e) => ReportActionContextMenu.showContextMenu(CONTEXT_MENU_TYPES.LINK, e, item.link, popoverAnchor)}

    onSecondaryInteraction={(e) =>
        ReportActionContextMenu.showContextMenu(
            CONTEXT_MENU_TYPES.LINK,
            e,
            item.link,
            popoverAnchor,
            undefined,
            undefined,
            undefined,
            undefined,
            undefined,
            undefined,
            undefined,
            undefined,
            undefined,
            undefined,
            false
        )
    }

Nice to have we can cleanup function ReportActionContextMenu.showContextMenu using an object params instead of argument params and call func look like this

  ReportActionContextMenu.showContextMenu({
    type: CONTEXT_MENU_TYPES.LINK,
    event: e,
    selection: item.link,
    contextMenuAnchor: popoverAnchor,
    isFocusCompose: false
  })

Demonstrate my change

28926.mp4

What alternative solutions did you explore? (Optional)

peterdbarkerUK · 2023-10-06T14:20:08Z

I wonder if the intention here is that the RHN should close upon copy-to-clipboard, and focus correctly returns to the composer. That makes more sense for me, as a user has already retrieved the link and would now want to navigate elsewhere. Asked in slack!

peterdbarkerUK · 2023-10-09T11:59:07Z

I was wrong, bug is correct as written - @mananjadhav could you take a look at the proposals here? Thanks!

mananjadhav · 2023-10-10T10:52:13Z

Based on the expected behavior @dukenv0307's proposal looks good.

🎀 👀 🎀 C+ review.

melvin-bot · 2023-10-10T10:52:19Z

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

luacmartins · 2023-10-10T16:40:51Z

I agree that @dukenv0307's proposal is good. Assigning to the issue.

melvin-bot · 2023-10-10T16:41:04Z

📣 @mananjadhav Please request via NewDot manual requests for the Reviewer role ($500)

melvin-bot · 2023-10-10T16:41:08Z

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-10T16:41:13Z

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2023-10-16T21:23:43Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-16T21:23:46Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: App focuses back on composer even if RHN is open on copy link from app download link in about settings #29254

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@mananjadhav does not require payment (Eligible for Manual Requests)
@dukenv0307 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:23:48Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:49:25Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix: App focuses back on composer even if RHN is open on copy link from app download link in about settings #29254

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@mananjadhav does not require payment (Eligible for Manual Requests)
@dukenv0307 requires payment offer (Contributor)
@dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:49:27Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
[@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mananjadhav] Determine if we should create a regression test for this bug.
[@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@peterdbarkerUK] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

peterdbarkerUK · 2023-10-24T15:00:09Z

Summarizing payouts for this issue:

Issue reporter: @dhanashree-sawant $50

Contributor: @dukenv0307 $750 (inc urgency bonus)

Contributor+: @mananjadhav $750 (inc urgency bonus) - @mananjadhav please complete the above checklist, notify me here, and then request payment via NewDot.

Upwork Job

mananjadhav · 2023-10-24T18:23:49Z

I think this change exists since a long time. I couldn't pinpoint it to a specific PR.

Neither do I think we need a regression test for this one. We've anyway fixed this at the Composer level, so less likely to occur again. cc - @peterdbarkerUK

JmillsExpensify · 2023-10-24T18:38:08Z

$750 payment approved for @mananjadhav based on summary above.

luacmartins · 2023-10-27T00:55:37Z

Just pending payment.

mananjadhav · 2023-10-27T18:28:49Z

@peterdbarkerUK Is the payout done for @dukenv0307 @dhanashree-sawant ? If yes then we're good to close here.

luacmartins · 2023-10-30T16:32:23Z

Just pending confirmation for the above

peterdbarkerUK · 2023-10-30T16:42:08Z

Yep, they were both paid last week! Job removed and closing :)

I'm sorry for the slow followup while I was OoO last week.

kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 5, 2023

melvin-bot bot changed the title ~~Chat - App refocuses on composer even when RHN is open~~ [$500] Chat - App refocuses on composer even when RHN is open Oct 5, 2023

melvin-bot bot assigned peterdbarkerUK Oct 5, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 5, 2023

melvin-bot bot assigned mananjadhav Oct 5, 2023

melvin-bot bot added the Overdue label Oct 9, 2023

melvin-bot bot removed the Overdue label Oct 9, 2023

melvin-bot bot assigned luacmartins Oct 10, 2023

luacmartins assigned dukenv0307 Oct 10, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 10, 2023

dukenv0307 mentioned this issue Oct 11, 2023

Fix: App focuses back on composer even if RHN is open on copy link from app download link in about settings #29254

Merged

59 tasks

melvin-bot bot changed the title ~~[$500] Chat - App refocuses on composer even when RHN is open~~ [HOLD for payment 2023-10-23] [$500] Chat - App refocuses on composer even when RHN is open Oct 16, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Oct 16, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-23] [$500] Chat - App refocuses on composer even when RHN is open~~ [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Chat - App refocuses on composer even when RHN is open Oct 16, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 Daily KSv2 labels Oct 23, 2023

melvin-bot bot added the Overdue label Oct 26, 2023

luacmartins changed the title ~~[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$500] Chat - App refocuses on composer even when RHN is open~~ [HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open Oct 27, 2023

melvin-bot bot removed the Overdue label Oct 27, 2023

melvin-bot bot added the Overdue label Oct 30, 2023

melvin-bot bot removed the Overdue label Oct 30, 2023

peterdbarkerUK closed this as completed Oct 30, 2023

idanbe4 mentioned this issue May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 be4solutions/App#10

Open

MelvinBot mentioned this issue May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42357

Closed

50 tasks

melvin-bot bot mentioned this issue May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open #28926

[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open #28926

kbecciv commented Oct 5, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 5, 2023

martin12345678900 commented Oct 5, 2023

dukenv0307 commented Oct 5, 2023 •

edited

Loading

chahedmoetaz commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

suneox commented Oct 5, 2023 •

edited

Loading

peterdbarkerUK commented Oct 6, 2023

peterdbarkerUK commented Oct 9, 2023

mananjadhav commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

luacmartins commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023

peterdbarkerUK commented Oct 24, 2023

mananjadhav commented Oct 24, 2023

JmillsExpensify commented Oct 24, 2023

luacmartins commented Oct 27, 2023

mananjadhav commented Oct 27, 2023

luacmartins commented Oct 30, 2023

peterdbarkerUK commented Oct 30, 2023

[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open #28926

[HOLD for payment 2023-10-23][$500] Chat - App refocuses on composer even when RHN is open #28926

Comments

kbecciv commented Oct 5, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023 • edited by peterdbarkerUK Loading

Bug0 Triage Checklist (Main S/O)

melvin-bot bot commented Oct 5, 2023

martin12345678900 commented Oct 5, 2023

dukenv0307 commented Oct 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

chahedmoetaz commented Oct 5, 2023

melvin-bot bot commented Oct 5, 2023

suneox commented Oct 5, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

peterdbarkerUK commented Oct 6, 2023

peterdbarkerUK commented Oct 9, 2023

mananjadhav commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

luacmartins commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 10, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 • edited by peterdbarkerUK Loading

melvin-bot bot commented Oct 16, 2023 • edited by peterdbarkerUK Loading

melvin-bot bot commented Oct 16, 2023 • edited by peterdbarkerUK Loading

melvin-bot bot commented Oct 16, 2023

peterdbarkerUK commented Oct 24, 2023

mananjadhav commented Oct 24, 2023

JmillsExpensify commented Oct 24, 2023

luacmartins commented Oct 27, 2023

mananjadhav commented Oct 27, 2023

luacmartins commented Oct 30, 2023

peterdbarkerUK commented Oct 30, 2023

kbecciv commented Oct 5, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 5, 2023 •

edited by peterdbarkerUK

Loading

dukenv0307 commented Oct 5, 2023 •

edited

Loading

suneox commented Oct 5, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by peterdbarkerUK

Loading