[HOLD for payment 2023-11-06] [$500] [Form Provider Refactor] LegalNamePage

[luacmartins]

Coming from #25397 (comment), we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Profile/PersonalDetails/LegalNamePage.js

cc @kowczarz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188894b16b3fbda4b
• Upwork Job ID: 1709704697533472768
• Last Price Increase: 2023-10-05
• Automatic offers:
• jjcoffee | Reviewer | 27243373

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188894b16b3fbda4b

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jjcoffee (Internal)

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kowczarz]

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

[melvin-bot]

Current assignee @jjcoffee is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

@tjferriss, @luacmartins, @jjcoffee, @kowczarz Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

@kowczarz is working on refactoring other pages, but will get to this one soon!

[kowczarz]

I will be able to start work on this next week.

[luacmartins]

@kowczarz is working on other related PRs, we'll get to this soon.

[luacmartins]

We're still working on other forms. Will get to this one soon!

[cdOut]

Hello, I'm Tymoteusz Kałuzieński from Software Mansion, the expert agency, and I would like to work on this task. Kamil reassigned it to me.

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

The BZ member will need to manually hire cdOut for the Contributor role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

[melvin-bot]

@tjferriss @luacmartins @jjcoffee @cdOut this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.92-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Form Provider Refactor] LegalNamePage #29785

If no regressions arise, payment will be issued on 2023-11-06. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment offer (Reviewer)
• @cdOut does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jjcoffee] The PR that introduced the bug has been identified. Link to the PR:
• [@jjcoffee] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@jjcoffee] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@jjcoffee] Determine if we should create a regression test for this bug.
• [@jjcoffee] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[luacmartins]

Pending BZ checklist and payment

[jjcoffee]

I guess no checklist is required here since it's not a bug?

[luacmartins]

Ah yea, sorry no checklist needed here

[tjferriss]

@jjcoffee payment has been made via Upworks.