[HOLD for payment 2023-10-23] [$500] [Form Provider Refactor] DateOfBirthPage

[luacmartins]

Coming from here, we created a new Form provider that works with functional components and we need to refactor all usages of the old Form component.

This issue is specific to refactoring src/pages/settings/Profile/PersonalDetails/DateOfBirthPage.js

cc @kowczarz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0109777ed46da69786
• Upwork Job ID: 1709704196813975552
• Last Price Increase: 2023-10-05

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0109777ed46da69786

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kowczarz]

Hello! I'm Kamil Owczarz from Software Mansion, the expert agency and I would like to work on this task.

[melvin-bot]

Current assignee @aimane-chnaif is eligible for the External assigner, not assigning anyone new.

[abekkala]

waiting on PR

Payments:

• Reporter: N/A
• C+: Software Mansion - no payment
• PR Reviewer: @aimane-chnaif

[kowczarz]

It will be done with #28879, because it would require big overload to provide two separate PRs

[aimane-chnaif]

Not Overdue

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Form migration NewDatePicker, DateOfBirthPage, EditRequestCreatedPage #29098

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @kowczarz does not require payment (Contractor)
• @aimane-chnaif requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@abekkala, @luacmartins, @kowczarz, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aimane-chnaif]

This is just refactor. No need checklist

[luacmartins]

Agree that we don't need the checklist for this one. Just waiting on payment.

[abekkala]

@aimane-chnaif I have been trying to send an payment offer but I keep getting this error from Upwork.
I'll keep trying!

[abekkala]

Finally!!
@aimane-chnaif offer sent! https://www.upwork.com/nx/wm/offer/27437905

[abekkala]

@aimane-chnaif payment sent and contract ended - thank you! 🎉