[HOLD for payment 2023-10-13] [HOLD for payment 2023-10-12] [$500] Contact Method - Reloading the page does not clear the error on Contact Methods

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to settings> profile > contact method
2. Click on Add contact method > Add a new contact method
3. Click on this contact method to verify
4. Enter a random magic code to make the error appear
5. Reload the page and notice the error

Expected Result:

Reloading the page clears the error

Actual Result:

Reloading the page does not clear the error

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native -missing
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.77-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

RPReplay_Final1696500134.MP4

XRecorder_04102023_175836.mp4

T154windows.Error.After.Reload-1.mp4

T154mac.Error.After.Reload-1.mp4

Screen_Recording_20231004_112702_Chrome.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @daveSeife
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696430803154119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a03426ab964ebd8c
• Upwork Job ID: 1709601906373169152
• Last Price Increase: 2023-10-04
• Automatic offers:
• s77rt | Contributor | 27025964
• daveSeife | Reporter | 27025966

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a03426ab964ebd8c

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[mountiny]

I dont think this is a blocker, curious if this is even a bug as the error is probably saved in onyx so you need to clear it with the X button and not with refresh. Same as if you get error when sending a message you need to clear the error with X

I am going to close this now thinking about it more, feel free to reopen if you disagree

[namhihi237]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Reload page can't clear the error

What is the root cause of that problem?

This issue was introduced from PR

Currently, we are having an error of not clearing some requests located in PERSISTED_REQUESTS after the API called

This leads to the same error return from the backend when calling API ValidateSecondaryLogin

The reason is because of this function

App/src/libs/actions/PersistedRequests.ts

Lines 29 to 40 in a7f070a

	function remove(requestToRemove: Request) {
	/**
	* We only remove the first matching request because the order of requests matters.
	* If we were to remove all matching requests, we can end up with a final state that is different than what the user intended.
	*/
	const index = persistedRequests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
	if (index === -1) {
	return;
	}
	persistedRequests.splice(index, 1);
	Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, persistedRequests);
	}

Currently, we are deleting persistedRequests directly and assigning them to PERSISTED_REQUESTS. This has caused some unexpected errors: it cannot delete some requests after the API is called.

What changes do you think we should make in order to solve the problem?

We should update the
We should clone persistentRequests to avoid unexpected errors.

function remove(requestToRemove: Request) {
    const index = persistedRequests.findIndex((persistedRequest) => isEqual(persistedRequest, requestToRemove));
    if (index === -1) {
        return;
    }
    const requests = [...persistedRequests];
    requests.splice(index, 1);
    Onyx.set(ONYXKEYS.PERSISTED_REQUESTS, requests);
}

What alternative solutions did you explore? (Optional)

N/A

[namhihi237]

@mountiny I think it's blocker, Currently we have error with PERSISTED_REQUESTS doesn't clear all request after they completed.

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @daveSeife 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[mountiny]

Fixed https://expensify.slack.com/archives/C9YU7BX5M/p1696456883868739

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix persisted request #28857

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Contributor)
• @namhihi237 requires payment
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: Update optimistic IDs in sequential queue #27996
• The offending PR has been commented on: Update optimistic IDs in sequential queue #27996 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.78-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix persisted request #28857

If no regressions arise, payment will be issued on 2023-10-13. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Contributor)
• @namhihi237 requires payment
• @daveSeife requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

Checklist provided already #28825 (comment)

[Christinadobrzyn]

still a few more days before payment.

Payouts due:

Issue Reporter: $50 @daveSeife (Paid in Upwork)
Contributor: $500 + $250 bonus @namhihi237 (Paid in Upwork)
Contributor+: NA based on #28825 (comment)

Eligible for 50% #urgency bonus? Yes - PR created Oct 4th - merged Oct 4th @s77rt @mountiny is that correct?

Upwork job is here.

[s77rt]

No payment due for me here since it's a regression from a PR I reviewed

[Christinadobrzyn]

Alright, paid based on #28825 (comment)

Closing!