Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the draft icon always be visible in the LHN when there is a draft #2807

Closed
bfitzexpensify opened this issue May 11, 2021 · 4 comments · Fixed by #2823
Closed

Have the draft icon always be visible in the LHN when there is a draft #2807

bfitzexpensify opened this issue May 11, 2021 · 4 comments · Fixed by #2823
Assignees

Comments

@bfitzexpensify
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Expected Result:

Show the draft 'pencil' for all chats, even the one you are currently looking at

Actual Result:

In e.cash, when a report has a draft comment, the LHN only shows the draft icon (pencil) visible for non-selected chats.

Action Performed:

  1. Select a chat
  2. Begin writing a comment
  3. Look at the LHN and there won't be a pencil icon
  4. Switch to another chat
  5. Look at the LHN and you'll see the pencil icon for the previous chat you were in

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Yes, though this will improve the experience.

Platform:

Where is this issue occurring?

All platforms

Version Number: All versions
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL: https://github.com/Expensify/Expensify/issues/163084

View all open jobs on Upwork

@MelvinBot
Copy link

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@parasharrajat
Copy link
Member

We have to remove the Active Reportcheck on line 88 from here
https://github.com/Expensify/Expensify.cash/blob/1f541bb4353a512ffcbec81731533e3ae3543b8b/src/libs/OptionsListUtils.js#L87-L91
and now icon would be visible for all chats in LHN.

@Julesssss
Copy link
Contributor

Looks good to me. @bfitzexpensify can we hire @parasharrajat please

@Julesssss Julesssss assigned parasharrajat and unassigned Julesssss May 12, 2021
@bfitzexpensify
Copy link
Contributor Author

Hired you @parasharrajat. Feel free to get cranking on a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants