Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create BZ checklist for all issues with new feature label. #27737

Closed
JmillsExpensify opened this issue Sep 19, 2023 · 11 comments
Closed

Create BZ checklist for all issues with new feature label. #27737

JmillsExpensify opened this issue Sep 19, 2023 · 11 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2

Comments

@JmillsExpensify
Copy link

JmillsExpensify commented Sep 19, 2023

We should be creating regression tests for all issues, no matter whether they are a bug or a new feature. Accordingly, let's ensure that the BZ checklist for new feature even though we aren't today.

This is an internal issue though creating in App for visibility.

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01632f7d35826f4e94
  • Upwork Job ID: 1703983742829371392
  • Last Price Increase: 2023-09-19
@JmillsExpensify JmillsExpensify added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. labels Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01632f7d35826f4e94

@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 19, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

@melvin-bot melvin-bot bot added the Overdue label Sep 27, 2023
@garrettmknight
Copy link
Contributor

Handling in the Expensify/Expensify issue.

@melvin-bot melvin-bot bot removed the Overdue label Sep 29, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@garrettmknight
Copy link
Contributor

Still working through the E/E issue - will leave this one open to test the update with.

@melvin-bot melvin-bot bot removed the Overdue label Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@flodnv] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@flodnv
Copy link
Contributor

flodnv commented Oct 17, 2023

Was just testing 👍

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@flodnv] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot
Copy link

melvin-bot bot commented Oct 17, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@flodnv] The PR that introduced the bug has been identified. Link to the PR:
  • [@flodnv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@flodnv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@flodnv] Determine if we should create a regression test for this bug.
  • [@flodnv] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2023
@garrettmknight
Copy link
Contributor

E/E issue is where we're working on this. This issue is open for testing. Will close it when the E/E issue closes.

@flodnv
Copy link
Contributor

flodnv commented Oct 20, 2023

New comment was posted here #28831 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants