[HOLD] warning: setNativeProps is deprecated

[marcaaron]

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c3301af71f9f2c5b
• Upwork Job ID: 1700244879840337920
• Last Price Increase: 2023-09-22

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[trjExpensify]

👋 what am I doing with this mate?

[marcaaron]

-> External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c3301af71f9f2c5b

[melvin-bot]

Current assignee @trjExpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

[trjExpensify]

Waiting for proposals.

[melvin-bot]

@trjExpensify, @narefyev91 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[trjExpensify]

Waiting for proposals.

[trjExpensify]

@marcaaron have any particular contributors been involved in knocking down setNativeProps related issues we can approach here?

[marcaaron]

Not that I know of. This looks like it's coming from an animation library though so maybe SWM can help.

[melvin-bot]

@trjExpensify @narefyev91 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[trjExpensify]

Cool, I can ask. Do you know where this shows up in the app? I don't see it in the console.

[narefyev91]

@trjExpensify just simply loading default page in web (in console last warning message)

[trjExpensify]

Ah, i was on the desktop app. I can see it after a refresh now, thanks!

[blazejkustra]

Not that I know of. This looks like it's coming from an animation library though so maybe SWM can help.

@marcaaron From what I see the error comes from @expensify/react-native-web, what makes you think that it comes from an animation library?

[blazejkustra]

There are a lot of libraries that use setNativeProps, from node_modules search:

BTW setNativeProps won't be even supported in Fabric, source.

We can't do much about this warning other than to patch the library and comment out the console log with the warning. I guess that would be my proposal for this issue 😅

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[marcaaron]

saw references to these in the warning trace:

[trjExpensify]

Chill Melv, @blazejkustra & @marcaaron are actively discussing.

[blazejkustra]

@marcaaron @trjExpensify These are animations from react-native/react-native-web (Animated). setNativeProps is what Animated uses to bypass setState. So as long as we use Animated I don't think we can do much about this warning, so either we refactor every usage of Animated to make sure it doesn't use setNativeProps internally or migrate animations to react-native-reanimated.

Is there a plan to replace Animated with Reanimated in the near future?

[marcaaron]

Is there a plan to replace Animated with Reanimated in the near future?

Not that I know of.

I think we can maybe keep this open though and just put it on HOLD then close whenever react-native-web fixes this.

As long as we are tracking it somewhere...

[trjExpensify]

Hm, okay. Is there anything to point to as a PR or issue with RNW that would fix this? Happy to pop [Hold] in the title but when we do that, we should point to what it's held on, not that it's indefinitely in the ether.

[marcaaron]

Update rnw maybe? Migrating off Animated could also be an option. Sorry I mainly created this issue because we have a checklist item that asks to create the issue if there are warnings in the JS console. If we want to ignore it and close the issue we can also do that, but it might pop up again which is why I recommended leaving it open and on HOLD.

If the main issue is the Daily and Bug labels being annoying then we can just drop them as this isn't really a "bug" 🤷‍♂️

[melvin-bot]

@marcaaron, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.