[$500] [Desktop ONLY] [Distance] - Current location feature is accessible when location access is disabled

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #25990

Action Performed:

Precondition: Location access on the device is disabled

1. Launch New Expensify app
2. Go to + > Request money > Distance
3. Tap 'Start'
4. Click Use current location

Expected Result:

App shows the error message 'We were unable to find your location, please try again or enter an address manually'

Actual Result:

The app is able to use current location feature despite not allowing location access on the device

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.61-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184903_20230901_183112.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d4f91fb1f56b7041
• Upwork Job ID: 1697617876228902912
• Last Price Increase: 2023-09-01

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

Web

Android

I confirmed that this is only occurring on Desktop and added a step to make the bug clearer.

But it's not a deploy blocker IMO as it is a new feature and only occuring on Desktop. So I'm going to remove the label. Let's get this fixed though!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d4f91fb1f56b7041

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[shubham1206agra]

Looks like mac is able to retrieve the location even though location service is off
In my case, it gave out my approximate location

[Julesssss]

Yeah, same here. But because of the following I would suggest we don't try to 'guess' the users location:

• This is very innacurate, and pretty useless for distance tracking
• It feels like a violation of my data

[hayata-suenaga]

is this only desktop?

[im-adithya]

Proposal:

We can use the permissions API to check if permission is available and then proceed

const permission = await navigator.permissions.query({ name: 'geolocation' })

[GItGudRatio]

I'm not able to repro, it somehow always seems to get the location once the map has loaded. I tried the staging build as well, still not able to repro

[huzaifa-99]

We are actually calling the maps API directly only for desktop. Should we add a check if the user has allowed permission and then call the API?

I will be fixing this with a new PR (taking changes from #25990)

cc: @hayata-suenaga @narefyev91

[Julesssss]

Only invoking the API when permission is granted seems reasonable to me, but lets see what @hayata-suenaga thinks.

This isn't the most important bug today, so it might need to wait.

[neil-marcellini]

Wow that's so weird that this works without location permission. Yes let's do an extra check for location permission and if it's not granted, handle it like an error, as described in the design doc plan in this issue description.

[huzaifa-99]

Sure i will do that in the new PR, @neil-marcellini.

[huzaifa-99]

Followup in PR here

[melvin-bot]

This issue has not been updated in over 15 days. @Julesssss, @CortneyOfstad, @thesahindia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hayata-suenaga]

Closing this issue as the issue is handled in the PR for a different issue