[HOLD for payment 2023-09-18] [HOLD for payment 2023-09-18] [$500] iPad - Page layout is broken in the landscape position

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Open Expensify App on iPad
2. Rotate iPad to landscape position
3. Check page layout

Expected Result:

The layout is not broken

Actual Result:

Page layout is broken in the landscape position

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• Apple iPad Pro / 16.6
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6184122_iPad-Landscape-Page-layout-broken.mp4

Bug6184122_iPad-Landscape-Page-layout-broken-STG-PROD.2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0101818de2158784ec
• Upwork Job ID: 1699050423953772544
• Last Price Increase: 2023-09-06
• Automatic offers:
• shubham1206agra | Contributor | 26559347

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

This is not one of our officially supported platforms so I'll demote it to NAB

[mountiny]

yeah this is from #22437 but this is not supported platform right now, curious that the rotation is not locked in

[aimane-chnaif]

All iPad bugs were closed, even critical.
i.e. #16612

[roryabraham]

We actually don't support landscape mode either. Maybe for now we should just make sure to disable landscape mode on iPad (I think it's disabled on iOS already?)

Long-term I would rather support iPad and landscape but I agree it's not a priority yet

[dangrous]

I just tested and it looks like portrait is messed up too, at least on a simulator. But if we're okay with just having this open in the background (I'd rather not fully close it) until we have bandwidth, that's fine by me

[mountiny]

@dangrous I think this is because the screen is so wide it thinks its wide screen and puts in that layout.

We should probably force the narrow layout in ipad and disable landscape, this can be external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0101818de2158784ec

[melvin-bot]

Triggered auto assignment to @abekkala (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[melvin-bot]

Upwork job price has been updated to $250

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.66-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] iPad layout fix (by forcing narrow layout) #27004
• [CP Staging] [NoQA] Require full screen for iOS #27016

If no regressions arise, payment will be issued on 2023-09-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @shubham1206agra requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[mountiny]

I think this should be sorted for now, but we still need to actually fix the layout in the landscape so making this Help Wanted still

[rushatgabhane]

@mountiny but we don't support landscape mode, right?

[mountiny]

Yeah but I think we might want to still fix this for ipad, I am not sure.
But yeah maybe its not something we should focus on, will remove the label and lets just pay out and close this

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.67-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] iPad layout fix (by forcing narrow layout) #27004
• [CP Staging] [NoQA] Require full screen for iOS #27016

If no regressions arise, payment will be issued on 2023-09-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rushatgabhane does not require payment (Eligible for Manual Requests)
• @shubham1206agra requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[abekkala]

PAYMENTS FOR SEPT 18

• Issue reported by: Applause
• Selected Proposal for fix: @shubham1206agra [$500] + [$250 PR bonus]
• C+ Review: @rushatgabhane [$500] + [$250 PR bonus] pay via EChat manual request

[abekkala]

@shubham1206agra payment sent and contract ended. Thank you! 🎉

[abekkala]

@rushatgabhane have you manually requested your payment in EChat yet?

[abekkala]

@rushatgabhane can you confirm if you've requested payment yet?

[rushatgabhane]

@abekkala requested payment https://staging.new.expensify.com/r/739012660970298
We can close this issue as it'll be tracked on newDot, thanks!

[JmillsExpensify]

$750 payment approved for @rushatgabhane based on BZ summary.