[HOLD for payment 2023-09-21] Bank account - Temporarily disabled message not displayed after 21 attempts

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #20747

Action Performed:

1. From NewDot, try adding a deposit account. Choose any Plaid bank, and enter 19 times some wrong credentials
2. Exit Plaid's modal. You should be able to choose a Plaid bank again. Enter 2 more wrong credentials
3. Exit Plaid's modal and try adding deposit account again

Expected Result:

User should not be able to use Plaid again

Actual Result:

Able to use plaid login again

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6183235_screen-20230830-161947.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[luacmartins]

FWIW I can also keep entering invalid credentials in prod, so I don't think this is a blocker

[luacmartins]

I'm gonna demote this to NAB since I could reproduce the behavior in prod. @nkuoch can you take a look at this one when you get a chance?

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[nkuoch]

@lanitochka17 can you tell me which email you tested it from in the video?

[lanitochka17]

@nkuoch applausetester+0606mnuu@applause.expensifail.com

[nkuoch]

PR in progress #26394

[alexpensify]

PR is still in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Restrict Plaid link on Native too #26394

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@nkuoch] The PR that introduced the bug has been identified. Link to the PR:
  Not a bug, more of a feature - we just never implemented it before
• [@nkuoch] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  N/A - Same as above
• [@nkuoch] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  N/A - Same as above
• [@nkuoch] Determine if we should create a regression test for this bug.
  No, not important enough to create one - especially as it's just something we created to prevent some users from overusing plaid in some situations, but not for all.
• [@nkuoch] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  N/A
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: N/A

[alexpensify]

@nkuoch - correct me if I'm wrong, but I don't think there's a payment here in Upwork.

Here is the payment summary:

• External issue reporter - Applause - Payment N/A
• Contributor that fixed the issue - Internal - Payment N/A
• Contributor+ that helped on the issue and/or PR - @ArekChr Payment via vendor

Upwork Job: N/A

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment:

[nkuoch]

ah yes sorry.

[alexpensify]

All good, I'm going to close this GH since there is no payment action here.