[$500] IOU Distance - Save button in waypoint editor is not responsive

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when executing PR #25984

Action Performed:

1. Go to staging.new.expensify,com
2. Go to + > Request money > Distance
3. Go to Start and select an address
4. Go to Start again and clear the address field
5. Click Save

Expected Result:

User is redirected to Distance page

Actual Result:

User is not redirected to Distance page. Save button is not responsive

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.59-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6182644_20230830_202346.mp4

Expensify/Expensify Issue URL:

Issue reported by: @b4s36t4

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b55cf7fbb4a3cad
• Upwork Job ID: 1706726189574373376
• Last Price Increase: 2023-09-26
• Automatic offers:
• b4s36t4 | Contributor | 26890787

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Li357 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[StevenKKC]

Proposal

Please state again the problem we are trying to solve in this issue.

IOU Distance - Save button in waypoint editor is not responsive.

What is the cause of this issue?

If we clear the address field and save, Transaction.removeWaypoint is called.

App/src/pages/iou/WaypointEditor.js

Lines 120 to 123 in 01d0d3b

	// Allows letting you set a waypoint to an empty value
	if (waypointValue === '') {
	Transaction.removeWaypoint(transactionID, waypointIndex);
	}

In Transaction.removeWaypoint, we call saveWaypoint with null of waypoint.

App/src/libs/actions/Transaction.js

Line 113 in 01d0d3b

saveWaypoint(transactionID, index, null);

Therefore, the following code throws an error, and then app will be unresponsive.

App/src/libs/actions/Transaction.js

Line 96 in 01d0d3b

const recentWaypointAlreadyExists = _.find(recentWaypoints, (recentWaypoint) => recentWaypoint.address === waypoint.address);

What changes do you think we should make to solve the problem?

We can return if waypoint is null in Transaction.saveWaypoint.

+   if (!waypoint) {
+       return;
+   }
    const recentWaypointAlreadyExists = _.find(recentWaypoints, (recentWaypoint) => recentWaypoint.address === waypoint.address);

What alternative solutions have you investigated? (Optional)

None.

[b4s36t4]

I have reported this bug earlier.
https://expensify.slack.com/archives/C049HHMV9SM/p1693286256793039

cc: @hayata-suenaga

[neil-marcellini]

I'm taking this over since it's a distance bug. Actually maybe the person who introduced this should take it if they are online.

[neil-marcellini]

I commented on the PR that caused this regression. We're discussing internally about having a contributor fix this in a PR that's in progress.

[hayata-suenaga]

The cause was identified and being fixed in the PR Neil mentioned above

[neil-marcellini]

Also not a blocker because it's under a beta

[melvin-bot]

@neil-marcellini Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@neil-marcellini Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@neil-marcellini Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@neil-marcellini 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

This issue has not been updated in over 14 days. @neil-marcellini eroding to Weekly issue.

[neil-marcellini]

This was fixed long ago. Idk where but that's ok.

[neil-marcellini]

Oh wait maybe we need to pay the reporting bonus. I'll assign BZ to do that.

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b55cf7fbb4a3cad

[melvin-bot]

📣 @b4s36t4 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[johncschuster]

@b4s36t4 can you please apply for the Reporter Role on Upwork? I'll take care of the reporting bonus after you've done that.

[b4s36t4]

@johncschuster above offer is for Contributor role mistakenly I have accepted it.

[b4s36t4]

What do I do?

[johncschuster]

@b4s36t4 No worries. I'll edit it on my end.

[johncschuster]

@b4s36t4 I've manually invited you to a different contract with the Bug Reporter rate. Can you accept that please?

[b4s36t4]

@johncschuster Accepted new offer. Thanks :)

[johncschuster]

Payment has been issued! Thanks, @b4s36t4!