[HOLD for payment 2023-09-04] Cannot delete or edit their own request

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

Break down in numbered steps

1. User A requests X from User B
2. User B request the same X from User A
3. User B cannot delete their request from the header
4. When you navigate tot he IOU report
5. Delete the money request from the popover menu

Expected Result:

Describe what you think should've happened

You should be able to delete requests you have made.

When deleting from the popover menu, the request is deleted

Actual Result:

Describe what actually happened

Unable to delete the request

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number:
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691836416831359

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0140d2e85164cfdf25
• Upwork Job ID: 1694687743326535680
• Last Price Increase: 2023-08-24

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[mountiny]

cc @luacmartins if you are interested

[tranvantoan-qn]

I have attached a screen recording here to make it easier for you to follow.

Delete-Request-Money-Error.mp4

[spcheema]

I got this response while deleting @mountiny

[mountiny]

The issue is interesting, for IOU reports the verification fails to confirm the user is owner of the transactions here becuase the cardID is linked to the user who is payer and thats because we link all the transactions on the IOU report to the payer (person who owes money) here.

This is really interesting issue @luacmartins

[luacmartins]

hmm we might have to add some new logic to check for the cardID and signs of each transaction as well 🤦

[mountiny]

I am really curious why we doing this and if we have to be doing this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0140d2e85164cfdf25

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @cubuspl42 (Internal)

[mountiny]

@tranvantoan-qn Can you please confirm this works now?

[tranvantoan-qn]

@mountiny
It worked, there is NO error when deleting the request and the Delete option is showing correctly for each sender

But I'm wondering how the navigation flow should work to avoid the Hm... It's not here page since the request/report is deleted - see video from 02:16

Issue-verification.mp4

[luacmartins]

@tranvantoan-qn we're investigating that as part of #25698

[mountiny]

Perfect so I think this is ready to pay out

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@mountiny Is the payout date 2023-08-30 or 2023-09-04?

[luacmartins]

Correct date should be 2023-09-04. This PR was deployed to production 3 days ago

[mananjadhav]

Okay thanks. @mountiny Is it safe to consider this a feature request? Also do we need a regression test here? I don't think we do.

[mountiny]

@mananjadhav This was a bug as there was backend issue with the permissions.

I think we need a regression test which will cover all the possible permission cases

[mananjadhav]

@mountiny Can we use the test steps from the PR?

[mountiny]

you can probably use those from the issue here yeah

[mananjadhav]

Okay thanks. Can @anmurali help here to add the regression tests? or can you take care of that @mountiny? I don't have the access to create those.

[mountiny]

Can you just write it down in the format that can be copy pasted and @anmurali will take care of that

[JmillsExpensify]

$1,000 payment approved via NewDot based on BZ summary.

[tranvantoan-qn]

@JmillsExpensify Can you send me the offer for the reporter role via Upwork?

[mountiny]

@JmillsExpensify @anmurali also reporting bonus $250 to @tranvantoan-qn please, thanks!

[JmillsExpensify]

No worries, I'll take it.

[JmillsExpensify]

@tranvantoan-qn Upwork job is now public here: https://www.upwork.com/jobs/~0140d2e85164cfdf25. Can you apply for $250 and I'll issue payment?

[tranvantoan-qn]

i've applied for the job, thanks!

[mountiny]

just waiting for the payment now

[JmillsExpensify]

Hired in Upwork.

[JmillsExpensify]

All paid out and contract closed. I think we're done here.