Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ON HOLD - Waiting on #26190] Dev - User is unable to unlink secondary contact method #25472

Closed
1 of 6 tasks
kavimuru opened this issue Aug 18, 2023 · 25 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Needs Reproduction Reproducible steps needed Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Add a secondary contact method email address B & leave it unverified
  2. Open a new window
  3. Navigate to a sign-up page
  4. Enter email address B
  5. Click on the Continue button

Expected Result:

User should navigate to unlink page where they can proceed to unlink the secondary contact method

Actual Result:

User is not navigated to the unlink page

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: DEV
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screencast.from.2023-08-18.09-31-56.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Natnael-Guchima
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692340650184629

View all open jobs on GitHub

@kavimuru kavimuru added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2023

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 18, 2023

Triggered auto assignment to @Beamanator (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Beamanator
Copy link
Contributor

Huh looks like we should be checking if that email was blocked, following https://stackoverflowteams.com/c/expensify/questions/16934

@Julesssss
Copy link
Contributor

Julesssss commented Aug 18, 2023

@Beamanator is this occurring on prod or staging?

@Julesssss
Copy link
Contributor

Julesssss commented Aug 18, 2023

As this was reported just 6 hours ago on dev, I feel like this should block the NEXT deployment and not 1.3.55-4.

If this isn't reproducible on staging/prod I'll check it off, but we'll need to re-add the label to get it on the next checklist

@Beamanator
Copy link
Contributor

Ya that makes sense to me 👍

@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@Beamanator Beamanator removed the DeployBlockerCash This issue or pull request should block deployment label Aug 21, 2023
@Beamanator
Copy link
Contributor

Removing blocker label, but will have to investigate soon (tomorrow morn)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Aug 21, 2023
@johncschuster
Copy link
Contributor

@Beamanator how's this one going?

@melvin-bot melvin-bot bot removed the Overdue label Aug 29, 2023
@Natnael-Guchima
Copy link

Last time I checked this was working fine. I can check it again and get back here.

@Beamanator
Copy link
Contributor

Thanks @Natnael-Guchima , that would be very helpful 🙏

@Natnael-Guchima
Copy link

Natnael-Guchima commented Aug 29, 2023

@Beamanator
I tested it 3 times, and it worked once and failed two times. And In the instance it worked, system doesn't navigate from 'unlink' page to 'sign-in' page. Similar issue happens when authenticating with magic link. GH issue link to similar issue where authenticating with magic link is not working.

2212_Trim.mp4
2023-08-29.10.20.25.mp4

@Beamanator Beamanator added Daily KSv2 and removed Hourly KSv2 labels Aug 30, 2023
@Beamanator
Copy link
Contributor

Thanks @Natnael-Guchima ! I will try to investigate tomorrow if this needs to be made internal or external

@Natnael-Guchima
Copy link

You are welcome 🙌

@melvin-bot
Copy link

melvin-bot bot commented Sep 1, 2023

@Beamanator @johncschuster this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Beamanator
Copy link
Contributor

Looks like this is now being worked on here: #26190 (the other linked issue was closed as a dupe)

@Natnael-Guchima do you think the linked issue will fix this too? We can put this on hold in the meantime

@Natnael-Guchima
Copy link

Natnael-Guchima commented Sep 3, 2023

@Beamanator it might solve the issue. We can put this on hold, and see if the other issue can fix this too.

I will test this again once the other isuse is deployed to staging, and I will let you know if this issue is fixed.

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@johncschuster johncschuster changed the title Dev - User is unable to unlink secondary contact method [ON HOLD - Waiting on https://github.com/Expensify/App/issues/26190]Dev - User is unable to unlink secondary contact method Sep 5, 2023
@johncschuster johncschuster changed the title [ON HOLD - Waiting on https://github.com/Expensify/App/issues/26190]Dev - User is unable to unlink secondary contact method [ON HOLD - Waiting on #26190] Dev - User is unable to unlink secondary contact method Sep 5, 2023
@johncschuster
Copy link
Contributor

johncschuster commented Sep 5, 2023

Thanks! I've put this one on hold and will downgrade it to a Weekly priority

@melvin-bot melvin-bot bot removed the Overdue label Sep 5, 2023
@johncschuster johncschuster added Weekly KSv2 and removed Daily KSv2 labels Sep 5, 2023
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2023
@Beamanator
Copy link
Contributor

still on hold

@melvin-bot melvin-bot bot removed the Overdue label Sep 26, 2023
@johncschuster johncschuster added Daily KSv2 and removed Daily KSv2 labels Sep 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@johncschuster
Copy link
Contributor

Still on hold

@melvin-bot melvin-bot bot removed the Overdue label Oct 5, 2023
@Natnael-Guchima
Copy link

I will test this to see if this is working fine since the holding pr is merged

@Natnael-Guchima
Copy link

@johncschuster this working fine now.

Screenshot 2023-10-06 at 7 11 38 AM

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@johncschuster
Copy link
Contributor

Great! Thanks for confirming that, @Natnael-Guchima! In that case, I'll go ahead and close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Needs Reproduction Reproducible steps needed Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants