Split bill - Split bill details page shows inactive fields

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap profile icon
3. Tap workspaces
4. Tap new workspace
5. Edit the workspace name and save
6. Tap members
7. Invite many members
8. Tap 3 dots of newly created workspace and go to #announce room
9. Tap plus icon to select split bill
10. Enter any amount
11. Tap split bill
12. Tap on the split bill box in conversation
13. Tap show more

Expected Result:

There should not be inactive fields in split bill details page

Actual Result:

Split bill details page shows inactive fields like date, amount, description etc

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.55-1
Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6168357_inactive.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ShogunFire]

I think that's intended for amount and description when you have already comfirmed the split, in the code it's disabled if didConfirm is true , in the code there is this comment though for date and merchant:

// Note: This component is disabled until this field is editable in next PR

That was made by that PR 3 weeks ago: #23648

[rayane-d]

I agree with @ShogunFire I think this is intended

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Split bill - Split bill details page shows inactive fields

What is the root cause of that problem?

We add isReadOnly prop as true to MoneyRequestConfirmationList. It makes all field in detail split bill page disable

What changes do you think we should make in order to solve the problem?

First, We need to confirm that which field we need to disable

1. For date and merchant field
   

   App/src/components/MoneyRequestConfirmationList.js

   Lines 408 to 420 in 2e838a1

   	<MenuItemWithTopDescription
   	title={props.iouDate}
   	description={translate('common.date')}
   	style={[styles.moneyRequestMenuItem, styles.mb2]}
   	// Note: This component is disabled until this field is editable in next PR
   	disabled
   	/>
   	<MenuItemWithTopDescription
   	title={props.iouMerchant}
   	description={translate('common.merchant')}
   	style={[styles.moneyRequestMenuItem, styles.mb2]}
   	// Note: This component is disabled until this field is editable in next PR
   	disabled

   
   We can remove disable field to enable 2 two fields
2. For amount and description field
   

   App/src/components/MoneyRequestConfirmationList.js

   Lines 373 to 389 in 2e838a1

   	<MenuItemWithTopDescription
   	shouldShowRightIcon={!props.isReadOnly}
   	title={formattedAmount}
   	description={translate('iou.amount')}
   	onPress={() => Navigation.navigate(ROUTES.getMoneyRequestAmountRoute(props.iouType, props.reportID))}
   	style={[styles.moneyRequestMenuItem, styles.mt2]}
   	titleStyle={styles.moneyRequestConfirmationAmount}
   	disabled={didConfirm || props.isReadOnly}
   	/>
   	)}
   	<MenuItemWithTopDescription
   	shouldShowRightIcon={!props.isReadOnly}
   	title={props.iouComment}
   	description={translate('common.description')}
   	onPress={() => Navigation.navigate(ROUTES.getMoneyRequestDescriptionRoute(props.iouType, props.reportID))}
   	style={[styles.moneyRequestMenuItem, styles.mb2]}
   	disabled={didConfirm || props.isReadOnly}

   
   We can remove props.isReadOnly in the disable condition

What alternative solutions did you explore? (Optional)

[melvin-bot]

@anmurali Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

What is the expected outcome here? We want the person that split the bill to be able to come back later and add these fields they originally didn't fill out? @lanitochka17

[lanitochka17]

@anmurali At least to be able to change the Description

[melvin-bot]

@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

Still waiting for a response from @lanitochka17

[melvin-bot]

@anmurali this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[lanitochka17]

@anmurali My answer was above:
At least to be able to change the Description

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[anmurali]

So to clarify in this video - the split bill itself cannot be edited to add a description. But the individual IOUs created from that split bill can be edited. You are saying the split bill should be editable?

Screen.Recording.2023-09-05.at.9.38.14.PM.mov

@lanitochka17

[melvin-bot]

@anmurali Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@anmurali Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Going to close this. @lanitochka17 please open when you respond.