Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250][TS migration] Migrate 'QRCode' component to TypeScript #25000

Closed
melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Closed

[$250][TS migration] Migrate 'QRCode' component to TypeScript #25000

melvin-bot bot opened this issue Aug 16, 2023 · 17 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 16, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/QRCode/index.js 5
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
@VickyStash
Copy link
Contributor

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 20, 2023

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'QRCode' component to TypeScript [HOLD for payment 2023-10-30] [TS migration] Migrate 'QRCode' component to TypeScript Oct 23, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2023
@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link
Author

melvin-bot bot commented Oct 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@roryabraham
Copy link
Contributor

@VickyStash I noticed that the QRCode module is a directory which only contains one index.tsx file. Can you do a quick follow-up PR to change it to just be a file called QRCode.tsx to follow the patterns established elsewhere in this repo?

@roryabraham roryabraham changed the title [HOLD for payment 2023-10-30] [TS migration] Migrate 'QRCode' component to TypeScript [TS migration] Migrate 'QRCode' component to TypeScript Oct 26, 2023
@roryabraham roryabraham removed the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 26, 2023
@VickyStash
Copy link
Contributor

@roryabraham Sure, I'll do it tomorrow

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Weekly KSv2 labels Oct 27, 2023
@melvin-bot melvin-bot bot added the Weekly KSv2 label Oct 27, 2023
@mananjadhav
Copy link
Collaborator

@AndrewGable can you assign me this as I helped with the Review checklist?

@mananjadhav
Copy link
Collaborator

@AndrewGable This was deployed to production, but the title for the payout wasn't updated. Can you help with that?

@AndrewGable AndrewGable changed the title [TS migration] Migrate 'QRCode' component to TypeScript [$250][TS migration] Migrate 'QRCode' component to TypeScript Nov 16, 2023
Copy link
Author

melvin-bot bot commented Nov 16, 2023

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@AndrewGable AndrewGable added the Bug Something is broken. Auto assigns a BugZero manager. label Nov 16, 2023
Copy link
Author

melvin-bot bot commented Nov 16, 2023

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 16, 2023
Copy link
Author

melvin-bot bot commented Nov 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 16, 2023
@AndrewGable
Copy link
Contributor

@greg-schroeder - Can you please pay out $250? Thanks

@mananjadhav
Copy link
Collaborator

@AndrewGable @greg-schroeder I think I'll only need a payment summary here. I can raise my request on NewDot.

@mananjadhav
Copy link
Collaborator

@greg-schroeder @AndrewGable quick bump on the payout summary here.

@greg-schroeder
Copy link
Contributor

Sorry, I was out most of the week for the holiday.

@greg-schroeder
Copy link
Contributor

@mananjadhav please make a manual request in NewDot for $250 for the reviewer role

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Reviewing Has a PR in review Task Typescript Migration
Projects
Development

No branches or pull requests

5 participants