Chat - Chat disappears & shows skeleton when going offline (web) or backgrounding the app (native)

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. IMPORTANT: Sign out and sign into the app again
2. Background the app
3. Bring the app into the foreground again

Expected Result:

The user expects the chats in the LHN to continue displaying throughout this entire process

Actual Result:

The chats are loading and displaying "skeletons" when the user switches the internet on and off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome
• MacOS / Desktop

Version Number: 1.3.54.7

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6165311_Chat_reloads_on_staging.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @madmax330 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dummy-1111]

I can't reproduce this

[madmax330]

I was able to reproduce, however, I don't think it's a blocker since the chat list loads up after you get back online

[marcaaron]

Coming from #25426 (comment) the repro steps are wrong we think. It has nothing to do with inviting a WS member. Just going offline and coming back is enough to trigger it. BUT...

1. You have to have logged in during that session (not rehydrating state from storage).
2. It's on production already so can't be a blocker.

[dummy-1111]

This issue can be fixed with this PR
Some modification might be needed

[marcaaron]

In this case we are good as it's on prod already, but this looks like an otherwise legitimate blocker to me. The offending PR is here.

[aldo-expensify]

This issue can be fixed with this PR
Some modification might be needed

what kind of modifications? Are you saying that it doesn't fix it in the current state?

[dummy-1111]

If there are only a few reports, turning back on internet would show skeleton below the exiting reports with the current PR
I'm not sure if this is expected

[dummy-1111]

I think we need to set the expectation here before moving forward

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

@madmax330, @bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

[madmax330]

@aldo-expensify going to assign you then since this is a regression cause by that PR you're assigned to.

[aldo-expensify]

PR under review

[aldo-expensify]

PR is in production, verified that it is working now:

Screen.Recording.2023-08-31.at.7.19.38.PM.mov

Screen.Recording.2023-08-31.at.7.21.25.PM.mov