CLEANUP: Remove an unnecessary ESLint rules from eslint-config-expensify

[hayata-suenaga]

Because we changed the style guideline to use object de-structuring to assign default values, `rulesdir/onyx-props-must-have-default': 'error' is no longer relevant. Remove the rule.

[spcheema]

@hayata-suenaga Is this available for external?

[hayata-suenaga]

@spcheema unfortunately it's not but thank you for your interest

[hayata-suenaga]

will do after TS migration is over

[hayata-suenaga]

melvin, TS migration is still going

[hayata-suenaga]

melvin, TS migration is still going

[hayata-suenaga]

TS migration is still going

[hayata-suenaga]

TS migration is nearing end

[hayata-suenaga]

TS migration is nearing end

[hayata-suenaga]

TS migration is nearing end

[hayata-suenaga]

changing this issue to weekly as the TS migration finishes in the App repo! 🚀

[blazejkustra]

Hey! I’m Błażej Kustra from Software Mansion, an expert agency, and I’d like to work on this issue!

[blazejkustra]

Because we changed the style guideline to use object de-structuring to assign default values, `rulesdir/onyx-props-must-have-default': 'error' is no longer relevant. Remove the rule.

@hayata-suenaga Let me know if there are any other rules that we need to remove, or maybe I should remove/adjust all rules conflicting with NewDot configuration?

[hayata-suenaga]

@blazejkustra some ESLint rules need to be removed from the Expensify ESlint, so I'll handle this 😄 🙇

[hayata-suenaga]

Removing onyx-props-must-have-default -> Expensify/eslint-config-expensify#92

[hayata-suenaga]

After the above PR is merged, we can update the version of the Expensify ESlint library specified in package.json

and also remove this line in eslint code that is manually turning off this rule now

[blazejkustra]

@blazejkustra some ESLint rules need to be removed from the Expensify ESlint, so I'll handle this 😄 🙇

Absolutely, all yours 😄 Let me know if there is anything I could help!

[melvin-bot]

This issue has not been updated in over 15 days. @hayata-suenaga eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[hayata-suenaga]

The two PRs were merge and deployed. I don't know why Melvin didn't remove the reviewing label. Closing the issue now 😄