[HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN #23446

kavimuru · 2023-07-23T20:05:00Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open 2 accounts on 2 browsers
Both account open the chat
B send any message
B click another report
A send the message, Observed in report B not marked as unread on LHN

Expected Result:

in report B marked as unread on LHN, when B does not open the report

Actual Result:

in report B not marked as unread on LHN

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-07-23.at.21.28.58.mov

Recording.1328.mp4

Expensify/Expensify Issue URL:
Issue reported by: @namhihi237
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1690006349415999

View all open jobs on GitHub

melvin-bot · 2023-07-23T20:05:05Z

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-23T20:05:07Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

StevenKKC · 2023-07-24T09:55:59Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unread not working on the LHN.

What is the root cause of that problem?

If user B received a message from user A, the following code is executed, and then calculate new marker actions.
If the scroll position is 0, then call Report.readNewestAction in order to update report's lastReadTime.

App/src/pages/home/report/ReportActionsView.js

Lines 129 to 153 in c779139

    
           unsubscribeFromNewActionEvent.current = Report.subscribeToNewActionEvent(props.report.reportID, (isFromCurrentUser, newActionID) => { 
        
               const isNewMarkerReportActionIDSet = !_.isEmpty(newMarkerReportActionID); 
        
               // If a new comment is added and it's from the current user scroll to the bottom otherwise leave the user positioned where 
        
               // they are now in the list. 
        
               if (isFromCurrentUser) { 
        
                   reportScrollManager.scrollToBottom(); 
        
                   // If the current user sends a new message in the chat we clear the new marker since they have "read" the report 
        
                   setNewMarkerReportActionID(''); 
        
               } else if (isReportFullyVisible) { 
        
                   // We use the scroll position to determine whether the report should be marked as read and the new line indicator reset. 
        
                   // If the user is scrolled up and no new line marker is set we will set it otherwise we will do nothing so the new marker 
        
                   // stays in it's previous position. 
        
                   if (currentScrollOffset.current === 0) { 
        
                       Report.readNewestAction(props.report.reportID); 
        
                       setNewMarkerReportActionID(''); 
        
                   } else if (!isNewMarkerReportActionIDSet) { 
        
                       // The report is not in view and we received a comment from another user while the new marker is not set 
        
                       // so we will set the new marker now. 
        
                       setNewMarkerReportActionID(newActionID); 
        
                   } 
        
               } else if (!isNewMarkerReportActionIDSet) { 
        
                   setNewMarkerReportActionID(newActionID); 
        
               } 
        
           });

In this issue, user B already navigates to another report, but previous report view is not unmounted, and still receive push event.
So when receive new action, Report.readNewestAction is called, and lastReadTime is updated.
Therefore, previous report does not marked as unread in LHN.

What changes do you think we should make in order to solve the problem?

We should add checking whether the report is visible (i.e. the current report) in new action event handler as below.

    unsubscribeFromNewActionEvent.current = Report.subscribeToNewActionEvent(props.report.reportID, (isFromCurrentUser, newActionID) => {
+       if (Navigation.getTopmostReportId() === props.report.reportID) {
+           return;
+       }

What alternative solutions did you explore? (Optional)

None.

stephanieelliott · 2023-07-24T21:00:18Z

Hey @kavimuru can you please clarify the on the repro steps? I'm not sure I understand how to test this:

Open 2 accounts on 2 browsers

I open Account A on Chrome, and Account B on Safari

Both account open the chat

On Account A I navigate to chat with Account B, on Account B I navigate to chat with Account A

B send any message

On Account B I send a message to Account A

B click another report

What does this mean -- on Account B should I be clicking into a chat with a separate user (Account X?) If no, what navigation steps should I be following?

A send the message, Observed in report B not marked as unread on LHN

On Account A I send a message to Account B. Is the expectation that Account B sees this chat as unread?

namhihi237 · 2023-07-24T21:46:59Z

Hi @stephanieelliott , All steps as you mention with step 4, I think you can click chat with Concierge. if not you can create any other report before.
Expectation: Account B sees this chat as unread on LHN => yes

mountiny · 2023-07-27T11:39:26Z

This was a fire and Hanno has been working on fixing it, pr is raised

hannojg · 2023-07-27T11:39:36Z

👋

melvin-bot · 2023-07-27T21:32:22Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-07-27T21:32:24Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.46-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix/regression unread messages #23729

If no regressions arise, payment will be issued on 2023-08-03. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hannojg does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-27T21:32:26Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hannojg] Determine if we should create a regression test for this bug.
[@hannojg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-07-31T18:22:20Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.47-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix/regression unread messages #23729

If no regressions arise, payment will be issued on 2023-08-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@hannojg does not require payment (Contractor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-07-31T18:22:22Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@mountiny] The PR that introduced the bug has been identified. Link to the PR:
[@mountiny] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mountiny] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@hannojg] Determine if we should create a regression test for this bug.
[@hannojg] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

mountiny · 2023-08-01T12:05:06Z

We will have to make a regression test for this @namhihi237 Are you able to suggest one please?

namhihi237 · 2023-08-01T14:30:25Z

Sure @mountiny

Regression Test Steps

Open 2 accounts on 2 browsers (2 accounts don't have a previous chat)
Both accounts open the chat together
Account B send any message
B click and open another report on LHN
A send the message, from B to verify that the report display is unread on LHN with user A

mountiny · 2023-08-06T18:14:20Z

Thanks! @stephanieelliott could we add this as a regression test please?

stephanieelliott · 2023-08-07T17:30:06Z

Issue for regression test here: https://github.com/Expensify/Expensify/issues/306359

stephanieelliott · 2023-08-07T17:36:11Z

Seems like no payment is due on this issue since it was a regression? Will leave this open for comment for one more day in case payment needs to be made.

namhihi237 · 2023-08-08T22:13:26Z

@stephanieelliott i am a reporter but seem i dont have any bonus for this issue? Cc @mountiny

stephanieelliott · 2023-08-09T13:17:53Z

Thanks @namhihi237, extended the offer to you in Upwork.

Summarizing payment on this issue:

Issue reporter: $250 @namhihi237, payment in Upwork
Contributor: N/A, expert contrib
Contributor+: N/A, regression

Upwork job is here https://www.upwork.com/jobs/~01256709c3bd79ab23

namhihi237 · 2023-08-09T13:19:48Z

Accepted, thanks @stephanieelliott

namhihi237 · 2023-08-11T14:28:35Z

Hi @stephanieelliott any update for this.

namhihi237 · 2023-08-15T02:23:29Z

Bump on this @stephanieelliott . I see the issue was closed.

stephanieelliott · 2023-08-15T02:55:42Z

Thanks for the reminder and sorry for the delay @namhihi237, I issued your payment in Upwork!

namhihi237 · 2023-08-15T02:56:29Z

Thanks @stephanieelliott

kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 23, 2023

melvin-bot bot assigned stephanieelliott Jul 23, 2023

tienifr mentioned this issue Jul 26, 2023

[$1000] New messages aren't showing up as unread and bold in LHN #23599

Closed

6 tasks

mountiny added the Reviewing Has a PR in review label Jul 27, 2023

mountiny self-assigned this Jul 27, 2023

mountiny mentioned this issue Jul 27, 2023

[CP Staging] Fix/regression unread messages #23729

Merged

58 tasks

mountiny removed the Reviewing Has a PR in review label Jul 27, 2023

mountiny assigned hannojg Jul 27, 2023

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Jul 27, 2023

melvin-bot bot changed the title ~~Unread not working on the LHN~~ [HOLD for payment 2023-08-03] Unread not working on the LHN Jul 27, 2023

melvin-bot bot removed the Reviewing Has a PR in review label Jul 27, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 31, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-08-03] Unread not working on the LHN~~ [HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN Jul 31, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 3, 2023

stephanieelliott closed this as completed Aug 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN #23446

[HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN #23446

kavimuru commented Jul 23, 2023

melvin-bot bot commented Jul 23, 2023

melvin-bot bot commented Jul 23, 2023

StevenKKC commented Jul 24, 2023 •

edited

Loading

stephanieelliott commented Jul 24, 2023 •

edited

Loading

namhihi237 commented Jul 24, 2023

mountiny commented Jul 27, 2023

hannojg commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

melvin-bot bot commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023

mountiny commented Aug 1, 2023

namhihi237 commented Aug 1, 2023

mountiny commented Aug 6, 2023

stephanieelliott commented Aug 7, 2023

stephanieelliott commented Aug 7, 2023

namhihi237 commented Aug 8, 2023 •

edited

Loading

stephanieelliott commented Aug 9, 2023

namhihi237 commented Aug 9, 2023

namhihi237 commented Aug 11, 2023

namhihi237 commented Aug 15, 2023

stephanieelliott commented Aug 15, 2023

namhihi237 commented Aug 15, 2023

[HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN #23446

[HOLD for payment 2023-08-07] [HOLD for payment 2023-08-03] Unread not working on the LHN #23446

Comments

kavimuru commented Jul 23, 2023

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 23, 2023

melvin-bot bot commented Jul 23, 2023

Bug0 Triage Checklist (Main S/O)

StevenKKC commented Jul 24, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

stephanieelliott commented Jul 24, 2023 • edited Loading

namhihi237 commented Jul 24, 2023

mountiny commented Jul 27, 2023

hannojg commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

melvin-bot bot commented Jul 31, 2023

melvin-bot bot commented Jul 31, 2023

mountiny commented Aug 1, 2023

namhihi237 commented Aug 1, 2023

mountiny commented Aug 6, 2023

stephanieelliott commented Aug 7, 2023

stephanieelliott commented Aug 7, 2023

namhihi237 commented Aug 8, 2023 • edited Loading

stephanieelliott commented Aug 9, 2023

namhihi237 commented Aug 9, 2023

namhihi237 commented Aug 11, 2023

namhihi237 commented Aug 15, 2023

stephanieelliott commented Aug 15, 2023

namhihi237 commented Aug 15, 2023

StevenKKC commented Jul 24, 2023 •

edited

Loading

stephanieelliott commented Jul 24, 2023 •

edited

Loading

namhihi237 commented Aug 8, 2023 •

edited

Loading