Update Header Link Style

[grgia]

Requirements:

• Entire line is clickable
• On hover, the blue text will use the link hover color and we will use the pointer mouse on web

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010c43c444f0847d77
• Upwork Job ID: 1678768484952473600
• Last Price Increase: 2023-07-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010c43c444f0847d77

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

[grgia]

@shawnborton just double checking here, should only the blue portion be clickable, or the entire line?

[shawnborton]

I'd say the entire line. I also wonder if we want to have some :hover feedback here? Like in the very least, the blue part can use our link hover color.

[JmillsExpensify]

Would love to get started on this one now that we merged the avatars PR.

[JmillsExpensify]

Also while I'm on the subject, I just want to make sure we're updating the second line, such that only the parentReport is hyperlinked. This is what we currently have in the app.

[shawnborton]

I think that's where we ended up. As I've said before, I don't feel strongly. I don't mind one entire clean blue link line underneath.

[JmillsExpensify]

Ah gotcha. I didn't realize that's where we ended. I think it's a bit much given that Expensify Contributors isn't actually something that you can click and navigate to. Like the only thing you can navigate to is the workspace chat, which for the admin is named Manan Jadhav in this specific case.

[trjExpensify]

Oh, is this not working on expenseReports like it is iouReports? 😕

[trjExpensify]

Sorry, maybe I'm confused by the issue. I think only the parent chat should be in blue and I agree with some hover feedback.

[JmillsExpensify]

Cool, I think I'm in the same place. I think it's a little confusing to make the entire sub-header blue, because it's actually referencing like two distinct things: the parentReport and the workspace chat. As a result, I think we should just make the parentReport blue, keeping the rest grey.

[JmillsExpensify]

Following up on that last comment, can we update how expense reports work, basically making them consistent with IOU reports?

[melvin-bot]

This issue has not been updated in over 15 days. @narefyev91, @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[trjExpensify]

I still think this should be weekly priority to fix the consistency.

[JmillsExpensify]

I actually think this is fixed now and should be closed? I also see that a week after I posted my screenshot above a linked PR was merged and deployed, so yeah I think this is done now. @grgia Do you mind confirming and closing this issue?

[JmillsExpensify]

All linked PRs are merged and I can't reproduce so I'm closing this out. Someone please re-open if anything remains.