-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Dev : On task view page header Title is not translated on Spanish #22516
Comments
Triggered auto assignment to @michaelhaxhiu ( |
Bug0 Triage Checklist (Main S/O)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.On task view page header Title is not translated on Spanish What is the root cause of that problem?The root cause is we have not add translation key for What changes do you think we should make in order to solve the problem?We just need to replace plain What alternative solutions did you explore? (Optional)N/A |
@jasperhuangg this is also regression from the same PR |
The title isn't a part of the default language, and is a custom user input, and therefore shouldn't need to change to Spanish when we update the locale to Spanish. That's kinda like saying any messages in the app sent in English should be translated to Spanish when we change the language to Spanish. Closing, not a bug. |
bug is about the label "title" for the title field and not the actual title @jasperhuangg |
@jasperhuangg I was referring to |
Ahh sorry for the confusion, will fix in my PR! |
As this will fix here #22586 this should be eligible for reporting as well @michaelhaxhiu |
Job added to Upwork: https://www.upwork.com/jobs/~011104443f63fd5252 |
Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat ( |
cool, we can pay the bug bonus as it was fixed after reported by timeline of events. upwork job created to pay bug bonus |
invited you to the job, post here when you accept plz! |
Accepted thanx you @michaelhaxhiu |
@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@michaelhaxhiu 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
@michaelhaxhiu this can be closed since regression period was over yesterday |
@michaelhaxhiu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
@michaelhaxhiu 12 days overdue now... This issue's end is nigh! |
This issue has not been updated in over 14 days. @michaelhaxhiu eroding to Weekly issue. |
Sorry for the delay, bug bonus is paid! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result: Title should be translated to Spanish
Actual Result: Title does not translated to Spanish
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: Dev
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688831625416919
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: