Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Dev : On task view page header Title is not translated on Spanish #22516

Closed
1 of 6 tasks
kavimuru opened this issue Jul 9, 2023 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Jul 9, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Login to ND
  2. Click on FAB button -> Click Assign task
  3. Enter title -> Click Next -> Select Share somewhere -> Click confirm task (Change language to Spanish)
  4. This will navigate to created task -> Notice Header of Title field
    Expected Result: Title should be translated to Spanish
    Actual Result: Title does not translated to Spanish

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: Dev
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshot 2023-07-08 at 9 23 56 PM

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688831625416919

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011104443f63fd5252
  • Upwork Job ID: 1679621464731418624
  • Last Price Increase: 2023-07-13
@kavimuru kavimuru added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Jul 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 9, 2023

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 9, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru
Copy link
Author

kavimuru commented Jul 9, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

On task view page header Title is not translated on Spanish

What is the root cause of that problem?

The root cause is we have not add translation key for title on taskView page

What changes do you think we should make in order to solve the problem?

We just need to replace plain title text to use props.translate('task.title’) which will translate as per language here https://github.com/Expensify/App/blob/60f48175c9e3342ef192d878218820e5ed5a76cd/src/components/ReportActionItem/TaskView.js#L68C28-L68C28

What alternative solutions did you explore? (Optional)

N/A

@chiragxarora
Copy link
Contributor

chiragxarora commented Jul 10, 2023

@jasperhuangg this is also regression from the same PR
#20841

@jasperhuangg
Copy link
Contributor

jasperhuangg commented Jul 10, 2023

The title isn't a part of the default language, and is a custom user input, and therefore shouldn't need to change to Spanish when we update the locale to Spanish.

That's kinda like saying any messages in the app sent in English should be translated to Spanish when we change the language to Spanish. Closing, not a bug.

@chiragxarora
Copy link
Contributor

chiragxarora commented Jul 10, 2023

bug is about the label "title" for the title field and not the actual title @jasperhuangg
And it's a regression from your PR as before that, it was translating

@dhairyasenjaliya
Copy link
Contributor

@jasperhuangg I was referring to title field 😃
Screenshot 2023-07-11 at 2 34 43 AM

@jasperhuangg
Copy link
Contributor

Ahh sorry for the confusion, will fix in my PR!

@dhairyasenjaliya
Copy link
Contributor

As this will fix here #22586 this should be eligible for reporting as well @michaelhaxhiu

@michaelhaxhiu michaelhaxhiu reopened this Jul 13, 2023
@michaelhaxhiu michaelhaxhiu added the External Added to denote the issue can be worked on by a contributor label Jul 13, 2023
@melvin-bot melvin-bot bot changed the title Dev : On task view page header Title is not translated on Spanish [$1000] Dev : On task view page header Title is not translated on Spanish Jul 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011104443f63fd5252

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Current assignee @michaelhaxhiu is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 13, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@michaelhaxhiu michaelhaxhiu removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 13, 2023
@michaelhaxhiu
Copy link
Contributor

cool, we can pay the bug bonus as it was fixed after reported by timeline of events. upwork job created to pay bug bonus

@michaelhaxhiu
Copy link
Contributor

invited you to the job, post here when you accept plz!

@jasperhuangg jasperhuangg added the Reviewing Has a PR in review label Jul 13, 2023
@dhairyasenjaliya
Copy link
Contributor

Accepted thanx you @michaelhaxhiu

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

@michaelhaxhiu Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2023

@michaelhaxhiu 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@dhairyasenjaliya
Copy link
Contributor

@michaelhaxhiu this can be closed since regression period was over yesterday

@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

@michaelhaxhiu Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot
Copy link

melvin-bot bot commented Jul 31, 2023

@michaelhaxhiu 12 days overdue now... This issue's end is nigh!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 3, 2023

This issue has not been updated in over 14 days. @michaelhaxhiu eroding to Weekly issue.

@michaelhaxhiu
Copy link
Contributor

Sorry for the delay, bug bonus is paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants