-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1000] Web - Assignee name and avatar is not dynamically updating after renaming from account B #22293
Comments
Triggered auto assignment to @slafortune ( |
Bug0 Triage Checklist (Main S/O)
|
Looks good! |
Job added to Upwork: https://www.upwork.com/jobs/~0138dda630214da2a7 |
Current assignee @slafortune is eligible for the External assigner, not assigning anyone new. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak ( |
This comment was marked as resolved.
This comment was marked as resolved.
Hey, I'm Marcin from Callstack - expert contributor group - I would like to take a look at this issue |
@eVoloshchak, @slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Heads up, I just closed a related issue with the same root cause: #22481. It's the same behavior, but on a different page (the task assignee contact list). Let's make sure that the fix here also fixes that other page. |
has the root cause been identified or just the behaviour? |
@Swor71 just the behavior, but the issue is the same, so I still think we should try to investigate both and fix together. |
Great! Assigning you @Swor71 ! |
📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000) |
📣 @eVoloshchak 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
📣 @nathan! 📣
|
The BZ member will need to manually hire Nathan for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future! |
@jliexpensify I tested the feature and indeed the "fake look up" was removed, which I think solves our issue because the assignee name and avatar not being changed was a problem for "local users" (the ones with fake data that would eventually be overwritten by an object with the proper user data). If, for instance, account A adds someone to a workspace and, while holding on the "Assign Task" action, the account B changes his/her information those are properly updated on the account A's screen, so it's working fine I think: Screen.Recording.2023-10-04.at.10.48.55.1.mov |
Ok nice! Shall we do it then? |
@puneetlath , I'm sorry, do what exactly? 😄 |
Bumping @puneetlath here - this comment sounds like the issue is fixed? |
@puneetlath, @eVoloshchak, @jliexpensify, @Swor71, @arthurmfgtab Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Waiting on Puneet - comment |
Not overdue |
Bumping @puneetlath to confirm that we can close this issue. |
Sorry for the delay! Sounds like we can indeed close the issue as long as everything is working as expected! |
Thanks Puneet - I'll just need to pay out the reporter first. PAYMENT SUMMARY
|
📣 @yashchaddha! 📣
|
Contributor details |
✅ Contributor details stored successfully. Thank you for contributing to Expensify! |
Hello all! I would like to contribute to this issue, can i be assigned on this one? |
@yashchaddha sorry, this issue is about to be closed. |
Oh Okay no problem @jliexpensify , saw it today on upwork, hence applied for it. Thankyou |
Ah sorry for the confusion - I created an issue to pay out the bug reporter. Just waiting for him to accept and it'll be closed out! |
No problem @jliexpensify |
Offer accepted @jliexpensify |
Paid and job closed! |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Action Performed:
Expected Result:
Both assignee and share somewhere avatar and name should dynamically update after renaming from account B
Actual Result:
Only share somewhere gets updated and assignee doesn't update dynamically.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.36-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Recording.3403.2.1.mp4
2023-07-04.08.34.14.1.mp4
Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688449071046279
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: