Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Web - Assignee name and avatar is not dynamically updating after renaming from account B #22293

Closed
6 tasks
kbecciv opened this issue Jul 5, 2023 · 98 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Jul 5, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open two new accounts (account A and account B)
  2. Go to account B and copy the email
  3. Go to account A and click on FAB > assign task > give a title > click next
  4. Click on assignee and paste the copied email and select it
  5. Go to account B and click on settings > name > rename it
  6. Click on the profile picture and give it a profile picture

Expected Result:

Both assignee and share somewhere avatar and name should dynamically update after renaming from account B

Actual Result:

Only share somewhere gets updated and assignee doesn't update dynamically.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.36-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Recording.3403.2.1.mp4
2023-07-04.08.34.14.1.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1688449071046279

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0138dda630214da2a7
  • Upwork Job ID: 1677356023664472064
  • Last Price Increase: 2023-08-17
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Jul 5, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@slafortune
Copy link
Contributor

Looks good!

@slafortune slafortune added the External Added to denote the issue can be worked on by a contributor label Jul 7, 2023
@melvin-bot melvin-bot bot changed the title Web - Assignee name and avatar is not dynamically updating after renaming from account B [$1000] Web - Assignee name and avatar is not dynamically updating after renaming from account B Jul 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0138dda630214da2a7

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Jul 7, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@BhuvaneshPatil

This comment was marked as resolved.

@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@Swor71
Copy link
Contributor

Swor71 commented Jul 10, 2023

Hey, I'm Marcin from Callstack - expert contributor group - I would like to take a look at this issue

@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

@eVoloshchak, @slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sakluger
Copy link
Contributor

Heads up, I just closed a related issue with the same root cause: #22481. It's the same behavior, but on a different page (the task assignee contact list). Let's make sure that the fix here also fixes that other page.

@Swor71
Copy link
Contributor

Swor71 commented Jul 11, 2023

Heads up, I just closed a related issue with the same root cause: #22481. It's the same behavior, but on a different page (the task assignee contact list). Let's make sure that the fix here also fixes that other page.

has the root cause been identified or just the behaviour?

@sakluger
Copy link
Contributor

@Swor71 just the behavior, but the issue is the same, so I still think we should try to investigate both and fix together.

@slafortune
Copy link
Contributor

Great! Assigning you @Swor71 !

@melvin-bot melvin-bot bot removed the Overdue label Jul 12, 2023
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jul 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

📣 @eVoloshchak Please request via NewDot manual requests for the Reviewer role ($1000)

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

📣 @eVoloshchak 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

📣 @nathan! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@melvin-bot
Copy link

melvin-bot bot commented Jul 12, 2023

The BZ member will need to manually hire Nathan for the Reporter role. Please store your Upwork details and apply to our Upwork job so this process is automatic in the future!

@arthurmfgtab
Copy link
Contributor

@jliexpensify I tested the feature and indeed the "fake look up" was removed, which I think solves our issue because the assignee name and avatar not being changed was a problem for "local users" (the ones with fake data that would eventually be overwritten by an object with the proper user data).

If, for instance, account A adds someone to a workspace and, while holding on the "Assign Task" action, the account B changes his/her information those are properly updated on the account A's screen, so it's working fine I think:

Screen.Recording.2023-10-04.at.10.48.55.1.mov

@puneetlath
Copy link
Contributor

Ok nice! Shall we do it then?

@arthurmfgtab
Copy link
Contributor

@puneetlath , I'm sorry, do what exactly? 😄

@melvin-bot melvin-bot bot added the Overdue label Oct 9, 2023
@jliexpensify
Copy link
Contributor

Bumping @puneetlath here - this comment sounds like the issue is fixed?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

@puneetlath, @eVoloshchak, @jliexpensify, @Swor71, @arthurmfgtab Whoops! This issue is 2 days overdue. Let's get this updated quick!

@jliexpensify
Copy link
Contributor

Waiting on Puneet - comment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 16, 2023
@jliexpensify
Copy link
Contributor

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 19, 2023
@jliexpensify
Copy link
Contributor

Bumping @puneetlath to confirm that we can close this issue.

@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2023
@puneetlath
Copy link
Contributor

Sorry for the delay! Sounds like we can indeed close the issue as long as everything is working as expected!

@jliexpensify
Copy link
Contributor

Thanks Puneet - I'll just need to pay out the reporter first.

PAYMENT SUMMARY

NEW UPWORKS JOB

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

📣 @yashchaddha! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@yashchaddha
Copy link

Contributor details
Your Expensify account email: yash.chaddha1997@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/chaddhayash

@melvin-bot
Copy link

melvin-bot bot commented Oct 26, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@yashchaddha
Copy link

Hello all! I would like to contribute to this issue, can i be assigned on this one?

@jliexpensify
Copy link
Contributor

@yashchaddha sorry, this issue is about to be closed.

@yashchaddha
Copy link

Oh Okay no problem @jliexpensify , saw it today on upwork, hence applied for it.

Thankyou

@jliexpensify
Copy link
Contributor

Ah sorry for the confusion - I created an issue to pay out the bug reporter. Just waiting for him to accept and it'll be closed out!

@yashchaddha
Copy link

No problem @jliexpensify

@Nathan-Mulugeta
Copy link

Offer accepted @jliexpensify

@jliexpensify
Copy link
Contributor

Paid and job closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests